Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor indentation fix for hpp workload field #60

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

geetikakay
Copy link
Contributor

@geetikakay geetikakay commented Sep 8, 2024

Minor indentation fix for hpp:

$ oc explain HostPathProvisioner.spec
GROUP:      hostpathprovisioner.kubevirt.io
KIND:       HostPathProvisioner
VERSION:    v1beta1
FIELD: spec <Object>
DESCRIPTION:
    HostPathProvisionerSpec defines the desired state of HostPathProvisioner
    FIELDS:
  featureGates	<[]string>
    FeatureGates are a list of specific enabled feature gates

  imagePullPolicy	<string>
    ImagePullPolicy is the container pull policy for the host path provisioner
    containers

  pathConfig	<Object>
    PathConfig describes the location and layout of PV storage on nodes.
    Deprecated

  storagePools	<[]Object>
    StoragePools are a list of storage pools

  workload	<Object>
    Restrict on which nodes HPP workload pods will be scheduled

Behavior with current code:

$ oc get HostPathProvisioner -A -o yaml
apiVersion: v1
items:
- apiVersion: hostpathprovisioner.kubevirt.io/v1beta1
  kind: HostPathProvisioner
  metadata:
    creationTimestamp: "2024-09-09T22:29:48Z"
    finalizers:
    - finalizer.delete.hostpath-provisioner
    generation: 10
    name: hostpath-provisioner
    resourceVersion: "638490"
    uid: 31892cf6-a239-4cd7-8d49-1b70a515ac34
  spec:
    imagePullPolicy: IfNotPresent
    storagePools:
    - name: localstorage
      path: /var/localstorage
    workload: {} --> workload is empty

After fix(with this patch)

....
items:
- apiVersion: hostpathprovisioner.kubevirt.io/v1beta1
....
  spec:
    imagePullPolicy: IfNotPresent
    storagePools:
    - name: localstorage
      path: /var/localstorage
    workload:
      nodeSelector:
        kubernetes.io/os: linux
        machineconfiguration.openshift.io/role: worker
  status:

Copy link
Contributor

@newkit newkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@newkit newkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@newkit newkit merged commit 3faf1af into sap-linuxlab:dev Sep 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants