sap_vm_provision: exec flow amendments from testing #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelmamula
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
LGTM after connectivity typo is resolved @sean-freeman I suppose removal of AWS and GCP from Readme is because Ansible collections are used instead of CLI, right?
@marcelmamula As there has been no reply yet from @sean-freeman, should we just assume that the answer to your question is |
Wabri
requested changes
Sep 12, 2024
roles/sap_vm_provision/tasks/platform_ansible/ibmcloud_powervs/execute_main.yml
Outdated
Show resolved
Hide resolved
roles/sap_vm_provision/tasks/platform_ansible/ibmcloud_vs/execute_setup_ha.yml
Outdated
Show resolved
Hide resolved
…/execute_main.yml Co-authored-by: GabrielePuliti <[email protected]>
…ute_setup_ha.yml Co-authored-by: GabrielePuliti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sap_vm_provision: exec flow amendments from testing