Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_vm_provision: Add optional AWS DNS overwrite #55

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

marcelmamula
Copy link
Contributor

Description:

  • Add optional variable sap_vm_provision_aws_dns_overwrite that can be used to overwrite existing DNS records.
  • Default: false
  • Defaults to false, if sap_vm_provision_aws_dns_overwrite is not boolean

NOTE: This is required to be set true for idempotency, but default handling retains parity between cloud implementations.

https://docs.ansible.com/ansible/latest/collections/amazon/aws/route53_module.html#parameter-overwrite

@marcelmamula marcelmamula added the enhancement New feature or request label Aug 12, 2024
@marcelmamula marcelmamula self-assigned this Aug 12, 2024
@sean-freeman
Copy link
Member

lgtm and suggest merge @marcelmamula

.... but reference to #56 - what would you prefer? Change PR to match prefix or change all the others?

Arguably all of these DNS PaaS Services provide Private DNS, and some go a bit further (like AWS Route53 where you could register the domain via the service, under the "public hosted zones" option).

We're only using the Private DNS capability of each, and there is no special handling for GCP DNS service (yet) in our code - hence it has no prefix and uses generic var sap_vm_provision_dns_root_domain only.

@marcelmamula marcelmamula merged commit 1f3f68d into sap-linuxlab:dev Aug 22, 2024
3 checks passed
@marcelmamula marcelmamula deleted the awsdns branch August 23, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants