sap_vm_provision: GCP improvements #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wait for ssh instead of pause - fail if resources were not found - enable post provisioning steps - documentation improvements
sean-freeman
requested changes
Aug 22, 2024
roles/sap_vm_provision/tasks/platform_ansible/gcp_ce_vm/execute_main.yml
Show resolved
Hide resolved
roles/sap_vm_provision/tasks/platform_ansible/gcp_ce_vm/execute_provision.yml
Show resolved
Hide resolved
|
@sean-freeman Updated based on comments and added fix for typos in HA code, which tried to call loop var in tasks without loop. |
sean-freeman
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
NOTE
Further improvements to HA provisioning might be needed after
sap_ha_pacemaker_clusterrole is reworked due to haproxy.