-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_vm_provision: feat: aws security enhancements #4
Conversation
@marcelmamula the change for Changes to Env Var approach to avoid use of |
@marcelmamula EDIT: On second thoughts, please remove |
As discussed separately and agreed, this PR contains - the hidden debugging var added for no_log, rename of task registered vars, remove environment var and declare secrets as module args, and a new rescue block that will output errors (that no_log will otherwise hide). This open PR merges these changes first, and I will append another PR for the other infrastructure platforms. lgtm 👍 Merge when ready |
PR covers following enhancements:
#1
Additionally covered:
Rescue block added for failed awscli calls.