Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_vm_provision: Azure compatibility update and fixes #36

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

marcelmamula
Copy link
Contributor

Scope:

  1. Updated hardcoded ssh-rsa to ssh- to allow ssh-ed25519 support
  2. Added second attempt for IAM Role creation to cover for bug New-AzureRmRoleDefinition - Name Already Exists Azure/azure-powershell#4365 (comment)
  3. Added retry loop to tasks that are fired too early, like gathering facts on newly built machine.
  4. Fixed typos in AZ Load balancer loop vars
  5. Updated Azure governance readme with detailed breakdown of Authentication actions, to offer more secure setup compared to privileged Contributor.
  6. Added os_register task to Azure for BYOS registration.
  7. Fixed loadbalancer STR<>INT conflicting code

@sean-freeman I am creating this PR now so you are aware of changes, but I will continue with more testing on Azure in coming weeks.

@marcelmamula marcelmamula added bug Something isn't working enhancement New feature or request labels Jun 14, 2024
@marcelmamula marcelmamula self-assigned this Jun 14, 2024
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed unit test, lgtm 👍

@sean-freeman sean-freeman merged commit b6ec291 into sap-linuxlab:dev Jun 19, 2024
3 checks passed
@marcelmamula marcelmamula deleted the azure branch June 26, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants