Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sap_hypervisor_node_preconfigure] updated trident and fixed variable name #3

Merged
merged 2 commits into from
Apr 13, 2024
Merged

[sap_hypervisor_node_preconfigure] updated trident and fixed variable name #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7766030
updated trident to 23.10; renamed variable switch for setting up work…
Feb 28, 2024
1953537
removed debug print
Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@

- name: Include setup worker nodes
ansible.builtin.include_tasks: "platform/{{ sap_hypervisor_node_platform }}/setup-worker-nodes.yml"
when: sap_hypervisor_node_preconfigure_setup_workers
when: sap_hypervisor_node_preconfigure_setup_worker_nodes

# How to wait for node to be scheduleable? (NodeSchedulable)
- name: Wait for all k8s nodes to be ready
Expand Down
4 changes: 2 additions & 2 deletions roles/sap_hypervisor_node_preconfigure/vars/platform_defaults_redhat_ocp_virt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ sap_hypervisor_node_preconfigure_install_hpp: false
sap_hypervisor_node_preconfigure_install_trident: false

# URL of the trident installer package to use
sap_hypervisor_node_preconfigure_install_trident_url: https://github.com/NetApp/trident/releases/download/v23.01.0/trident-installer-23.01.0.tar.gz
sap_hypervisor_node_preconfigure_install_trident_url: https://github.com/NetApp/trident/releases/download/v23.10.0/trident-installer-23.10.0.tar.gz

# should SRIOV be enabled for unsupported NICs
sap_hypervisor_node_preconfigure_sriov_enable_unsupported_nics: true
Expand All @@ -27,4 +27,4 @@ sap_hypervisor_node_preconfigure_ignore_minimal_memory_check: false
sap_hypervisor_node_preconfigure_install_operators: true

# Configure the workers?
sap_hypervisor_node_preconfigure_setup_workers: true
sap_hypervisor_node_preconfigure_setup_worker_nodes: true