sap_vm_provision: allow Private DNS Records for hosts to be overwritten

[marcelmamula]

sap_vm_provision: Add overwrite: true to Ansible AWS Route53 DNS Records for hosts

@sean-freeman Current implementation works great idempotently but gets stopped on route53 step because it will not overwrite by default.

TASK [community.sap_infrastructure.sap_vm_provision : Ansible AWS Route53 DNS Records for hosts] *********************************************
fatal: [nw750abaphdb -> localhost]: FAILED! => {"changed": false, "msg": "Record already exists with different value. Set 'overwrite' to replace it"}

community.sap_infrastructure/roles/sap_vm_provision/tasks/platform_ansible/aws_ec2_vs/execute_main.yml

Line 64 in a67f6b8

- name: Ansible AWS Route53 DNS Records for hosts

[sean-freeman]

Will need to implement a new default variable sap_vm_provision_aws_private_dns_overwrite: false to this PR (use common var name pattern _private_dns because new vars have been requested for MS Azure Private DNS also).

This will also require:

• sap_vm_provision_gcp_private_dns_overwrite
• sap_vm_provision_ibmcloud_private_dns_overwrite
• sap_vm_provision_msazure_private_dns_overwrite

[sean-freeman]

OK so the default action of Ansible if there is a conflict, is not to enact a change. Appending any 'destructive' behaviour (i.e. destroy this DNS Record with the same name, and create the DNS Record with new values) would be an optional choice through a variable.

I have looked through the Ansible Modules called by sap_vm_provision and whether this additional variable is possible while retaining homogeneity:

• amazon.aws.route53 has a parameter overwrite ✅
• google.cloud.gcp_dns_resource_record_set has no handling for existing/conflicting records ❌
• ibm.cloudcollection.ibm_dns_resource_record legacy module has no handling for existing/conflicting records ❌
• azure.azcollection.azure_rm_privatednsrecordset has a parameter record_mode: purge (default) ⚠️ which is unclear if this handles overwrite (I think so)

As not all vendors allow this capability, we cannot introduce an _overwrite boolean. Execution behaviour should be equal on this, and personally I don't believe in any destruction of DNS Records in case an end-user has made a mistake.

Change not approved, and this GH Issue should be closed.