Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Allow intention management with labels #12

Open
webknjaz opened this issue Jul 4, 2019 · 4 comments
Open

[RFC] Allow intention management with labels #12

webknjaz opened this issue Jul 4, 2019 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@webknjaz
Copy link
Member

webknjaz commented Jul 4, 2019

Idea

Project maintainers should be able to set labels instructing the bot to omit or enforce requiring change fragments.

Implementation

If bot:chronographer:skip label is set, the bot should report a neutral status.
Otherwise, the bot should set bot:chronographer:required label if the fragment is missing and bot:chronographer:provided if it's there.
The bot should allow maintainers to set bot:chronographer:more if the fragment is present but needs to be updated/extended or maybe if the PR needs several fragments. The bot should report "action_required". Once the requirement is fulfilled, the bot must remove this label.

Ref: tox-dev/tox#1364 (comment)

Fund with Polar
@webknjaz webknjaz added enhancement New feature or request help wanted Extra attention is needed labels Jul 4, 2019
@webknjaz
Copy link
Member Author

@asottile @gaborbernat @asvetlov does above look reasonable?

@gaborbernat
Copy link

Sounds good to me 👍

@asvetlov
Copy link

  1. bot:chronographer:required is 25-chars line. Does it fit into GitHub UI well?
  2. I don't understand the purpose of bot:chronographer:more. If the CHANGELOG record is incorrect -- reviewer points on it in review message, that's it. How does bot determine that the label should be removed?
  3. What is the purpose of adding bot:chronographer:provided label? To use it in PR filers?

@webknjaz
Copy link
Member Author

Does it fit into GitHub UI well?

LGTM: gh-bot-req-label

How does bot determine that the label should be removed?

I think on the change to that file or adding a new one.

To use it in PR filers?

Yep, more or less.

webknjaz added a commit that referenced this issue Aug 20, 2021
webknjaz added a commit that referenced this issue Mar 9, 2023
This patch will allow the end users to set their own label name for
letting the bot ignore missing changelog fragments in PRs.

Ref: #12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants