Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt-out the tagging by bot:chronographer:provided #40

Closed
praiskup opened this issue Aug 30, 2024 · 4 comments
Closed

opt-out the tagging by bot:chronographer:provided #40

praiskup opened this issue Aug 30, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@praiskup
Copy link

praiskup commented Aug 30, 2024

This tag is not needed in our case - it is enough to see a failed CI check mark.

It would be nice to have an option to turn off tagging.

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@webknjaz
Copy link
Member

Ref #12

@webknjaz webknjaz added the enhancement New feature or request label Aug 30, 2024
@webknjaz
Copy link
Member

Sounds reasonable. We'd need to decide the shape/UX of the config for this, though. Perhaps

labels:
  changelog-detected: change note found  # default: `bot:chronographer:provided`, disable with `~`

would do. ~ is an equivalent of None / null in YAML, IIRC. Needs checking, though.

If somebody wants to make a PR, here's the places where this would need to be integrated:

And the config-related examples are here:

Make sure to follow the existing code style around, I don't remember if I configured many linters.

@webknjaz
Copy link
Member

webknjaz commented Sep 1, 2024

@praiskup I've gone for the following UX:

labels:
  fragment-provided: ~  # opt out

The feature is live. Give it a try.

@praiskup
Copy link
Author

praiskup commented Sep 2, 2024

And it worked in rpm-software-management/mock#1393 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants