Master merge from develop #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update readme file
Upgrade Ruby 3.1.2 -> 3.3.4
Update rubocop 1.64.1 → 1.65.0 (minor)
Update rubocop-rspec 3.0.1 → 3.0.3 (patch)
🚨 [security] Update rexml 3.3.1 → 3.3.2 (patch)
Rename aliquot table's lims_uuid column to aliquot_uuid
re-committing the branch to resolve conflicts
add new column to the Study table.
dasunpubudumal
assigned BenTopping and andrewsparkes and unassigned andrewsparkes and BenTopping
yoldas
reviewed
Jul 29, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM ruby:3.1.2 | |||
| FROM ruby:3.3.4 | |||
There was a problem hiding this comment.
Could you please confirm that the version is available from Docker Hub?
There was a problem hiding this comment.
Yes, it is available
| gem 'sanger_warren' | ||
| gem 'bunny', '>= 2.22.0' | ||
| gem 'rbtree', '~> 0.4.5' | ||
| gem 'sanger_warren', '~> 0.4.1' |
There was a problem hiding this comment.
Is there a repo for sanger_warren ? Where does this come from ?
There was a problem hiding this comment.
sanger_warren is available in RubyGems 😄
yoldas
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes proposed in this pull request
Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code
[Production Merges to
main]- Check story numbers included
- Check for debug code
- Check version