Merge pull request #678 from sanger/675-y24-316-as-developers-we-want…

…-to-increase-the-size-of-the-id-sample-lims-column-in-the-sample-table-to-255

Increase size of id_sample_lims column in sample table

db/migrate/20240919134424_increase_size_of_id_sample_lims_column_in_sample.rb

@@ -0,0 +1,9 @@
+class IncreaseSizeOfIdSampleLimsColumnInSample < ActiveRecord::Migration[7.0]
+  def up
+    change_column :sample, :id_sample_lims, :string, limit: 255
+  end
+
+  def down
+    change_column :sample, :id_sample_lims, :string, limit: 20
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[7.0].define(version: 2024_08_14_125331) do
+ActiveRecord::Schema[7.0].define(version: 2024_09_19_134424) do
   create_table "aliquot", charset: "utf8mb3", collation: "utf8mb3_unicode_ci", force: :cascade do |t|
     t.string "id_lims", null: false, comment: "The LIMS system that the aliquot was created in"
     t.string "aliquot_uuid", null: false, comment: "The UUID of the aliquot in the LIMS system"
@@ -305,7 +305,7 @@
   create_table "sample", primary_key: "id_sample_tmp", id: { type: :integer, unsigned: true }, charset: "utf8mb3", collation: "utf8mb3_unicode_ci", force: :cascade do |t|
     t.string "id_lims", limit: 10, null: false, comment: "LIM system identifier, e.g. CLARITY-GCLP, SEQSCAPE"
     t.string "uuid_sample_lims", limit: 36, comment: "LIMS-specific sample uuid"
-    t.string "id_sample_lims", limit: 20, null: false, comment: "LIMS-specific sample identifier"
+    t.string "id_sample_lims", null: false, comment: "LIMS-specific sample identifier"
     t.datetime "last_updated", precision: nil, null: false, comment: "Timestamp of last update"
     t.datetime "recorded_at", precision: nil, null: false, comment: "Timestamp of warehouse update"
     t.datetime "deleted_at", precision: nil, comment: "Timestamp of sample deletion"
@@ -463,7 +463,7 @@
     t.string "programme"
     t.index ["accession_number"], name: "study_accession_number_index"
     t.index ["id_lims", "id_study_lims"], name: "study_id_lims_id_study_lims_index", unique: true
-    t.index ["id_study_lims"], name: "index_study_on_id_study_lims", unique: false
+    t.index ["id_study_lims"], name: "index_study_on_id_study_lims"
     t.index ["name"], name: "study_name_index"
     t.index ["uuid_study_lims"], name: "study_uuid_study_lims_index", unique: true
   end

db/views_schema.rb

@@ -29,4 +29,4 @@
       'lh_biosero_cp_error_recovered_destination_plate_completed','lh_biosero_cp_error_recovered_destination_plate_partial_completed'
     )
 SQL
-)
+)

spec/models/sample_spec.rb

@@ -28,7 +28,7 @@
 
     let(:json) do
       {
-        'id' => 1,
+        'id' => '1' * 255.to_i,
         'name' => 'name',
         'reference_genome' => 'reference genome',
         'organism' => 'organism',