Update rubocop-rspec 3.2.0 → 3.3.0 (minor) #1509

depfu · 2024-12-13T19:00:29Z

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (3.2.0 → 3.3.0) · Repo · Changelog

Release Notes

3.3.0

Deprecate top_level_group? method from TopLevelGroup mixin as all of its callers were intentionally removed from Rubocop/RSpec. (@corsonknowles)

Fix false positive for RSpec/EmptyMetadata for splat kwargs. (@pirj)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 30 commits:

✳️ rubocop (1.68.0 → 1.69.2) · Repo · Changelog

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.7.5 → 2.9.0) · Repo · Changelog

Release Notes

2.9.0

What's Changed

Fix C implementation of script_safe escaping to not confuse some other 3 wide characters with \u2028 and \u2029.
e.g. JSON.generate(["倩", "瀨"], script_safe: true) would generate the wrong JSON.

JSON.dump(object, some_io) now write into the IO in chunks while previously it would buffer the entire JSON before writing.

JSON::GeneratorError now has a #invalid_object attribute, making it easier to understand why an object tree cannot be serialized.

Numerous improvements to the JRuby extension.

Full Changelog: v2.8.2...v2.9.0

2.8.2

What's Changed

JSON.load_file: explictly load the file as UTF-8

Full Changelog: v2.8.1...v2.8.2

2.8.1

Fix the java version of the package to include the extension implementation. Only concerns JRuby.

Full Changelog: v2.8.0...v2.8.1

2.8.0

What's Changed

Emit a deprecation warning when JSON.load create custom types without the create_additions option being explictly enabled.
- Prefer to use JSON.unsafe_load(string) or JSON.load(string, create_additions: true).
Emit a deprecation warning when serializing valid UTF-8 strings encoded in ASCII_8BIT aka BINARY.
Bump required Ruby version to 2.7.
Add support for optionally parsing trailing commas, via allow_trailing_comma: true, which in cunjunction with the
pre-existing support for comments, make it suitable to parse jsonc documents.
Many performance improvements to JSON.parse and JSON.load, up to 1.7x faster on real world documents.
Some minor performance improvements to JSON.dump and JSON.generate.

Parsing performance

Parsing performance is improved by 50-70% on realistic benchmarks, and even more on micro-benchmarks: https://gist.github.com/casperisfine/cf4b3a0594fae24b7d0eb93daaf3841a

== Parsing activitypub.json (58160 bytes)
ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]
Warming up --------------------------------------
          json 2.7.2   638.000 i/100ms
                  oj   798.000 i/100ms
          Oj::Parser   948.000 i/100ms
           rapidjson   631.000 i/100ms
Calculating -------------------------------------
          json 2.7.2      6.423k (± 1.3%) i/s  (155.70 μs/i) -     32.538k in   5.067149s
                  oj      7.989k (± 1.0%) i/s  (125.17 μs/i) -     40.698k in   5.094544s
          Oj::Parser      9.472k (± 1.3%) i/s  (105.58 μs/i) -     47.400k in   5.005119s
           rapidjson      6.354k (± 1.1%) i/s  (157.37 μs/i) -     32.181k in   5.064962s
Comparison:

json 2.8.0:     9510.0 i/s

Oj::Parser:     9471.9 i/s - same-ish: difference falls within error

oj:     7989.4 i/s - 1.19x  slower

json 2.7.2:     6422.5 i/s - 1.48x  slower

rapidjson:     6354.5 i/s - 1.50x  slower
== Parsing twitter.json (567916 bytes)

ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]

Warming up --------------------------------------

json 2.7.2    52.000 i/100ms

oj    64.000 i/100ms

Oj::Parser    76.000 i/100ms

rapidjson    57.000 i/100ms

Calculating -------------------------------------

json 2.7.2    526.860 (± 3.8%) i/s    (1.90 ms/i) -      2.652k in   5.042680s

oj    631.234 (± 1.7%) i/s    (1.58 ms/i) -      3.200k in   5.070973s

Oj::Parser    764.354 (± 3.5%) i/s    (1.31 ms/i) -      3.876k in   5.077736s

rapidjson    579.085 (± 2.8%) i/s    (1.73 ms/i) -      2.907k in   5.024620s
Comparison:

json 2.8.0:      884.0 i/s

Oj::Parser:      764.4 i/s - 1.16x  slower

oj:      631.2 i/s - 1.40x  slower

rapidjson:      579.1 i/s - 1.53x  slower

json 2.7.2:      526.9 i/s - 1.68x  slower
== Parsing citm_catalog.json (1727030 bytes)

ruby 3.4.0dev (2024-11-06T07:59:09Z precompute-hash-wh.. 7943f98a8a) +YJIT +PRISM [arm64-darwin24]

Warming up --------------------------------------

json 2.7.2    30.000 i/100ms

oj    35.000 i/100ms

Oj::Parser    45.000 i/100ms

rapidjson    40.000 i/100ms

Calculating -------------------------------------

json 2.7.2    304.584 (± 3.3%) i/s    (3.28 ms/i) -      1.530k in   5.029021s

oj    358.572 (± 0.8%) i/s    (2.79 ms/i) -      1.820k in   5.076123s

Oj::Parser    450.643 (± 3.1%) i/s    (2.22 ms/i) -      2.295k in   5.098150s

rapidjson    395.304 (± 1.5%) i/s    (2.53 ms/i) -      2.000k in   5.060537s
Comparison:

json 2.8.0:      449.8 i/s

Oj::Parser:      450.6 i/s - same-ish: difference falls within error

rapidjson:      395.3 i/s - 1.14x  slower

oj:      358.6 i/s - 1.25x  slower

json 2.7.2:      304.6 i/s - 1.48x  slower

Full Changelog: v2.7.3...v2.8.0

2.7.6

Fix a regression in JSON.generate when dealing with Hash keys that are string subclasses, call to_json on them.

Full Changelog: v2.7.5...v2.7.6

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.3.5.1 → 3.3.6.0) · Repo · Changelog

Release Notes

3.3.6.0 (from changelog)

API modifications:

Bump maintenance branches to 3.3.6 (#1045) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 4 commits:

↗️ regexp_parser (indirect, 2.9.2 → 2.9.3) · Repo · Changelog

Release Notes

2.9.3 (from changelog)

Fixed

fixed positive lookbehinds with character ">" being treated as named groups

e.g. (?<=foo>)

thanks to Daniel Vandersluis

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 5 commits:

↗️ rubocop-ast (indirect, 1.33.0 → 1.37.0) · Repo · Changelog

Release Notes

1.36.2 (from changelog)

Bug fixes

#340: Handle anonymous splats in MlhsNode. (@earlopain)

1.36.1 (from changelog)

Bug fixes

#339: Do not emit a deprecation warning for EnsureNode#body to give RuboCop a chance to update its usage. EnsureNode#body will still be changed in the next major version of rubocop-ast. (@earlopain)

1.36.0 (from changelog)

Changes

#337: Deprecate EnsureNode#body in favour of EnsureNode#branch. EnsureNode#body will be redefined in the next major version of rubocop-ast. (@dvandersluis)

1.35.0 (from changelog)

New features

#333: Add BeginNode for kwbegin nodes. (@dvandersluis)

Changes

#333: Add EnsureNode#rescue_node method. (@dvandersluis)

1.34.1 (from changelog)

New features

#329: Add Node#type? to reduce complexity of checking against multiple node types. (@dvandersluis)

#330: Extend Node#const_name to casgn nodes. (@dvandersluis)

Bug fixes

#331: [Fix #331] Fix crash in OpAsgnNode#name when the lhs is a send or csend node. (@dvandersluis)

1.34.0 (from changelog)

New features

#326: Introduce lhs and rhs aliases to assignment nodes for consistency. (@dvandersluis)

1.33.1 (from changelog)

Bug fixes

#325: Allow non_bare_access_modifier_declaration? to handle modifiers with multiple arguments. (@dvandersluis)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 46 commits:

↗️ unicode-display_width (indirect, 2.6.0 → 3.1.2) · Repo · Changelog

Release Notes

3.1.2 (from changelog)

Performance improvements

3.1.1 (from changelog)

Performance improvements

3.1.0 (from changelog)

Improve Emoji support:

Emoji modes: Differentiate between well-formed Emoji (:possible) and any ZWJ/modifier sequence (:all). The latter is more common and more efficient to implement.

Unify rgi_{fqe,mqe,uqe} options to just :rgi to keep things simpler (corresponds to the former :rgi_uqe option). Most terminals that want to support the RGI set will probably want to catch Emoji sequences with missing VS16s.

Add new :all_no_vs16 and :rgi_at modes to be able to support some terminals that needs these quirks

Add alias emoji: :auto for emoji: true and emoji: :none for emoji: false

:auto mode: Only consider terminal cells when recommending Emoji support level (Emoji themselves might display differently)

:auto mode: Set default Emoji mode for unknown/unsupported terminals to :none

Rename :basic mode to :vs16

3.0.1 (from changelog)

Add WezTerm and foot as good Emoji terminals

3.0.0 (from changelog)

Rework Emoji support:

Emoji widths are now enabled by default

Only reduce Emoji width to 2 when RGI Emoji detected (configurable)

VS16 turns Emoji characters of width 1 into full-width

Please note that Emoji parsing has a notable impact on performance. You can use the emoji: false option to disable Emoji adjustments

Tries to detect terminal's Emoji support level automatically (from ENV vars)

Index fixes and updates:

Private-use characters are considered ambiguous (were given width 1 before)

Fix that a few zero-width ignorable codepoints from recent Unicode were missing

Consider the following separators to be zero-width:

U+2028 - LINE SEPARATOR - Zl

U+2029 - PARAGRAPH SEPARATOR - Zp

Other:

Add keyword arguments to Unicode::DisplayWidth.of. If you are using a hash with overwrite values as third parameter, be sure to put it in curly braces.

Using third parameter or explicit hash as fourth parameter is deprecated, please migrate to the keyword arguments API

Gem raises ArgumentError for ambiguous values other than 1 or 2

Performance optimizations

Require Ruby 2.5

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 47 commits:

🆕 unicode-emoji (added, 4.0.4)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

codecov · 2024-12-13T19:06:01Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (54c5f43) to head (e133c3a).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1509   +/-   ##
========================================
  Coverage    97.93%   97.93%           
========================================
  Files          428      428           
  Lines        13479    13479           
========================================
  Hits         13201    13201           
  Misses         278      278

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Update rubocop-rspec to version 3.3.0

e133c3a

depfu bot added dependencies Pull requests that update a dependency file Technical Debt Technical Debt labels Dec 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop-rspec 3.2.0 → 3.3.0 (minor) #1509

Update rubocop-rspec 3.2.0 → 3.3.0 (minor) #1509

depfu bot commented Dec 13, 2024

codecov bot commented Dec 13, 2024

Update rubocop-rspec 3.2.0 → 3.3.0 (minor) #1509

Are you sure you want to change the base?

Update rubocop-rspec 3.2.0 → 3.3.0 (minor) #1509

Conversation

depfu bot commented Dec 13, 2024

What changed?

✳️ rubocop-rspec (3.2.0 → 3.3.0) · Repo · Changelog

3.3.0

✳️ rubocop (1.68.0 → 1.69.2) · Repo · Changelog

↗️ json (indirect, 2.7.5 → 2.9.0) · Repo · Changelog

2.9.0

What's Changed

2.8.2

What's Changed

2.8.1

2.8.0

What's Changed

Parsing performance

2.7.6

↗️ parser (indirect, 3.3.5.1 → 3.3.6.0) · Repo · Changelog

3.3.6.0 (from changelog)

↗️ regexp_parser (indirect, 2.9.2 → 2.9.3) · Repo · Changelog

2.9.3 (from changelog)

Fixed

↗️ rubocop-ast (indirect, 1.33.0 → 1.37.0) · Repo · Changelog

1.36.2 (from changelog)

Bug fixes

1.36.1 (from changelog)

Bug fixes

1.36.0 (from changelog)

Changes

1.35.0 (from changelog)

New features

Changes

1.34.1 (from changelog)

New features

Bug fixes

1.34.0 (from changelog)

New features

1.33.1 (from changelog)

Bug fixes

↗️ unicode-display_width (indirect, 2.6.0 → 3.1.2) · Repo · Changelog

3.1.2 (from changelog)

3.1.1 (from changelog)

3.1.0 (from changelog)

3.0.1 (from changelog)

3.0.0 (from changelog)

🆕 unicode-emoji (added, 4.0.4)

codecov bot commented Dec 13, 2024

Codecov Report