DPL-1111-2: Refactor message management #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use the module __init__.py file to expose the public classes.
sdjmchattie
force-pushed
the
dpl-1111-2-refactor-message-management
branch
from
252bdd0 to
784304b
Compare
Only those properties that have unique behaviours have their own class. Those that just store a string now use the StringValue class. The message property that holds any kind of value is now just called Value. DictValue holds the dictionary equivalent of a MessageProperty.
stevieing
approved these changes
Mar 1, 2024
StephenHulme
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
That's quite the refactor! I'm afraid I'm not able to do a proper line-by-line comparison due to all the file moves and large chunks changed - but I guess that's the nature of the game.
A couple tiny comments, but probably would benefit from an even closer eye over the code?
tol_lab_share/messages/properties/complex/scientific_name_from_taxon_id.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #66
Changes proposed in this pull request
__init__.pyfiles to export classes from module. This improves the number of imports needed.Instructions for Reviewers
[All PRs] - Confirm PR template filled
[Feature Branches] - Review code