Update rubocop-rails 2.24.1 → 2.25.1 (minor) #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
|
@depfu rebase |
depfu
bot
force-pushed
the
depfu/update/rubocop-rails-2.25.1
branch
from
c6d7d45 to
c1bb7c0
Compare
SHIV5T3R
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop-rails (2.24.1 → 2.25.1) · Repo · Changelog
Release Notes
2.25.1
2.25.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 54 commits:
Cut 2.25.1Update ChangelogUse RuboCop RSpec 3.0Merge pull request #1297 from ChaelCodes/1295-rails-validations-covers-comparison[Fix #1295] Cover validates_comparison_of in Rails/ValidationMerge pull request #1300 from Earlopain/changelog-tweaksConsistently specify department in current changelog entriesMerge pull request #1299 from Earlopain/error-not-null-columnFix an error for `Rails/NotNullColumn` when the block for `change_table` is emptyMerge pull request #1289 from fwolfst/1288-let_link_to_blank_find_link_to_if_and_unlessadd link_to_if and link_to_unless to matched callsUse `sh` instead of `system cmd, exception: true` in *.rakeMerge pull request #1293 from fatkodima/where-range-unsafe[Fix #1283] Mark `WhereRange` as unsafe autocorrectMerge pull request #1292 from fatkodima/fix-where-range-complex-expressionsMerge pull request #1291 from fatkodima/fix-where_range-spaces[Fix #1281] Fix `WhereRange` autocorrect for complex expressions[Fix #1282] Fix `WhereRange` to correctly handle template strings with extra spacesMerge pull request #1284 from ccutrer/fix-change-column-null-in-bulk-change-table[Fix #1280] Handle change_column_null for BulkChangeTableMerge pull request #1290 from Earlopain/badge-circleciFix readme CI badgeMerge pull request #1287 from koic/mark_rails_skips_model_validations_as_unsafe[Fix #1286] Mark `Rails/SkipsModelValidations` as unsafeSuppress a RuboCop's offenseSwitch back docs version to masterCut 2.25.0Update ChangelogMerge pull request #1279 from tldn0718/fix-skip-model-validation-safe-navigator[Fix rubocop#1278] Fix a false positivie for Rails/SkipsModelValidationsMerge pull request #1277 from thiago-gitlab/rails-pick-descriptionWarn about subqueries when replacing pluck with pickMerge pull request #1275 from koic/restore_skipping_specs_for_prismMerge pull request #1265 from ccutrer/not-null-column-docsRestore skipped specs for PrismMerge pull request #1266 from ccutrer/inspect_change_table_for_not_null_columnMerge pull request #1272 from fatkodima/where_range-copMerge pull request #1267 from tldn0718/http-status-assertionsAdd new `Rails/WhereRange` copSuppress offenses of `InternalAffairs/ExampleDescription`Merge pull request #1271 from koic/fix_an_incorrect_autocorrect_for_rails_validation[Fix #1270] Fix an incorrect autocorrect for `Rails/Validation`Merge pull request #1137 from amomchilov/migrate-to-requires_gem-apiUse `requires_gem` API in `TargetRailsVersion`Make Rails/HttpStatus award of Rails specific response assertionsRails/NotNullColumn: Inspect change_table calls for offenses[Fix #237] Improve documentation for Rails/NotNullColumnMerge pull request #1252 from Earlopain/disable-unused-ignored-columnsUse RuboCop Performance 1.21Merge pull request #1263 from jherdman/protect-against-pretend-generatesProtect against pretend generatesMerge pull request #1262 from lukasfroehlich1/fix_unknown_env_mutate[Fix #1260] Fix performance regression caused by `Rails/UnknownEnv` on Rails >= 7.1Switch back docs version to master✳️ minitest (5.22.3 → 5.24.1) · Repo · Changelog
Release Notes
5.24.1 (from changelog)
5.24.0 (from changelog)
5.23.1 (from changelog)
5.23.0 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 23 commits:
Branching minitest to version 5.24.1- Fix the error message when an extension is invalid value. (y-yagi)prepped for release+ Added Minitest.register_plugin.Remove more anacronisms. Allow tests to pass w/o rubygems loaded.- Removed anacronism, but allow load_plugins to exit gracefully if --disable=gems.Fix one failing tests when string literals are frozen.Moved some methods around to follow actual call structure a bit better.prepped for release- Fully qualify the Queue class to avoid conflicts with other libraries. (rafaelfranca)Branching minitest to version 5.23.0+ Added -Werror to raise on any warning output. (byroot)Added testW0 rake task.Fixed specs task for pattern_match expectation mapping.OMG... Rake.verbose returns Object.new if unset. Fixed by ruby/rake#567, but until then, compare against true.Updated versions/EOL for ruby/rails in readme+ Added minitest/manual_plugins.rb w/ new Minitest.load method. (tenderlove)- Make test task verbose using either rake's -v or -t (was just -t).- Allow empty_run! and reporter to display summary for empty runs. (zzak)Ignore unused block. (ko1)Make the test suite compatible with --enable-frozen-string-literal. (casperisfine)oopsBump ci.yml to include ruby 3.3, singularize macos, and clean up deprecations on the checkout action (should I remove the version?!? so annoying)✳️ rubocop (1.65.0 → 1.65.1) · Repo · Changelog
Commits
See the full diff on Github. The new version differs by 41 commits:
Cut 1.65.1Update ChangelogMerge pull request #13083 from Earlopain/false-positive-global-std-streamFix false positive for `Style/GlobalStdStream` for namespaced constantsClarify docs in Naming/PredicateNameAdd a validate_config for Naming/PredicateNameMerge pull request #13079 from koic/fix_incorrect_autocorrect_for_naming_rescued_exceptions_variable_nameMerge pull request #13081 from fatkodima/zero_length_predicate-false-positiveFix a false positive for `Style/ZeroLengthPredicate` when using safe navigation and non-zero comparison[Fix #13076] Fix an incorrect autocorrect for `Naming/RescuedExceptionsVariableName`Merge pull request #13075 from koic/mark_broken_on_prism_for_broken_specs_for_ruby34_with_prismMark `broken_on: :prism` for broken specs using Ruby 3.4.0dev with PrismEnable branch coverage[Fix #11438] Explicitly load `fileutils` before calculating `before_us`[Doc] Tweak the doc of `Layout/AssignmentIndentation`Merge pull request #13071 from Earlopain/bump-simplecovBump `simplecov`Merge pull request #13069 from Earlopain/regexp_parser_cruftDrop `regexp_parser` < 2.0 compatibility codeMerge pull request #13066 from koic/fix_an_error_for_lint_useless_assignment_cop[Fix #13065] Fix an error for `Lint/UselessAssignment`Merge pull request #13062 from Earlopain/invertible-unless-empty-bracesFix an error for `Style/InvertibleUnlessCondition` when using empty parenthesis as conditionRemove an unused private method[Docs] Fix code example for `Lint/ShadowingOuterLocalVariable`[Docs] Consistent usage of `@example`Clarify how to specify the number of parallel processesFix a typo[Docs] Tweak the v1 Upgrade Notes[Fix #13044] Fix false negatives for `Lint/ImplicitStringConcatenation`[Fix #13051] Fix an error for `Lint/FloatComparison`Merge pull request #13043 from koic/fix_false_positives_for_lint_useless_assignmentMerge pull request #13047 from m11o/feature/fix-warningUse `support_autocorrect?` class method.[Fix #13041] Fix false positives for `Lint/UselessAssignment`Merge pull request #13040 from koic/tweak_autocorrect_for_style_sole_nested_conditionalTweak autocorrect for `Style/SoleNestedConditional`Use `RuboCop::AST::Node#equals_asgn?`[Docs] Tweak the doc of `Style/EvalWithLocation`Remove an unused private methodReset the docs versionRelease Notes
1.3.3
1.3.2
1.3.1
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 30 commits:
1.3.3Improve speed for windows `Get-CimInstance`1.3.2Add a windows job to CIRemove dependency on `win32ole`Automatically run bundle install before running testsRelease edge 0.7.1Make it possible to publish edge without baseEnsure JRuby is used in release testsFix concurrent-ruby-edge to depend on `~> MAJOR.MINOR` of concurrent-rubyGet RakeCompilerDock to work with either podman or docker, based on what is installedFix method name in CHANGELOG.mdPromoting 1.3.1.pre to 1.3.1.Prepare a 1.3.1.pre gem to test things for the 1.3.1 release.Prepare the 1.3.1 release.Prepare the 1.3.0 release.Fix a small grammar issue.Align Java Executor Service behavior for `shuttingdown?`, `shutdown?`Add 10 minute timeout to GitHub ActionsClarifyCleanupsAdd Concurrent.usable_processor_count that is cgroups awareUse 'ruby' for dynamic latest CRuby releaseAdvance "latest" ruby in isolated ci test job to 3.3No continue-on-error for head RubiesBump actions/checkout from 3 to 4Bump actions/deploy-pages from 1 to 4Bump actions/upload-pages-artifact from 1 to 3Fix link label in signpost.mdCI: Tell dependabot to update GH ActionsRelease Notes
1.14.5
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 18 commits:
Bump to 1.14.5Merge pull request #688 from Bilka2/escaped-reserved-interpolationMerge pull request #691 from tom-lord/interpolate_documentation_syntax_fixMerge branch 'master' into interpolate_documentation_syntax_fixMerge pull request #682 from tom-lord/add_I18n.interpolation_keysMerge pull request #692 from uiur/optimize-fallbacks-computeRemove unnecessary lineUse left recursionOptimize I18n::Locale::Fallbacks#computeAdd note about not altering strings when no params are givenMerge pull request #690 from amatsuda/bundle_raccFix syntax in documentation for I18n::Backend::Base.interpolateFix example docMore examples documentedModify behaviour for Hash and (maybe nested) Array translationsAdd tests and error handling for non-string translationsracc has been extracted to a gem since Ruby 3.3Fix that escaped interpolations for reserved keywords raised an errorRelease Notes
2.6.17 (from changelog)
2.6.16 (from changelog)
2.6.15 (from changelog)
2.6.14 (from changelog)
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 29 commits:
Ready for 2.6.17Fix log message when eager loading a directory endsReady for 2.6.16Remove ruby-lsp from the GemfileIntroduces the private class Zeitwerk::CrefAdd ruby-lsp to the GemfileMerge pull request #295 from kianmeng/fix-typosFix typosLog directories being ignored for having no Ruby fileReword and reorder logging testReady for 2.6.15Refator while loop conditionOptimizes looking for at least one Ruby fileEnable --enable-frozen-string-literal in CIRewordingsRewording in the READMEReady for 2.6.14Restore the original Zeitwerk::NameError messageDocumentation tweaksDocument Zeitwerk::Loader#all_expected_cpathsExclude macOS/2.5 from CI matrixStandardize breadth-first loopsLet the ls helper yield the file type tooImplements Zeitwerk::Loader#all_expected_pathsFix indentationAdd a test for Zeitwerk::NameErrorFurther revise the Zeitwerk::NameError messageReword Zeitwerk::NameError message againPolish Zeitwerk::NameError messageDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands