Rubocop (for rubocop upgrade)

sanger · Aug 2, 2024 · 489ac29 · 489ac29
1 parent c1bb7c0
commit 489ac29
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/test/controllers/lots_controller_test.rb b/test/controllers/lots_controller_test.rb
@@ -153,7 +153,7 @@ class LotsControllerTest < ActionController::TestCase
 
     get :search, params: { lot_number: '123456789' }
 
-    assert_response 300
+    assert_response :multiple_choices
     assert_select 'h1', 'Multiple lots found'
     assert_select 'h3', 'IDT Tags'
     assert_select 'h3', 'IDT Reporters'

diff --git a/test/controllers/qc_assets_controller_test.rb b/test/controllers/qc_assets_controller_test.rb
@@ -53,7 +53,7 @@ class QcAssetsControllerTest < ActionController::TestCase
     @request.headers['Accept'] = 'application/json'
     get :search, params: { user_swipecard: 'abcdef', asset_barcode: '122000000867' }
 
-    assert_response 404
+    assert_response :not_found
   end
 
   test 'search with children' do
@@ -409,7 +409,7 @@ def state
            sibling: test[:sibling_bc]
       }
       if test[:success]
-        assert_response 302
+        assert_response :found
       else
         presenter = assigns['presenter']
         assert_equal 'Presenter::Error', presenter.class.to_s
@@ -519,7 +519,7 @@ def state
            sibling: test[:sibling_bc]
       }
       if test[:success]
-        assert_response 302
+        assert_response :found
       else
         presenter = assigns['presenter']
         assert_equal 'Presenter::Error', presenter.class.to_s

diff --git a/test/controllers/robots_controller_test.rb b/test/controllers/robots_controller_test.rb
@@ -32,6 +32,6 @@ class RobotsControllerTest < ActionController::TestCase
        .raises(Sequencescape::Api::ResourceNotFound, 'There is an issue with the API connection to Sequencescape (["no resources found with that search criteria"])')
 
     post :search, params: { robot_barcode: '1234567890123' }
-    assert_response 404
+    assert_response :not_found
   end
 end
diff --git a/test/controllers/users_controller_test.rb b/test/controllers/users_controller_test.rb
@@ -32,6 +32,6 @@ class UsersControllerTest < ActionController::TestCase
 
     post :search, params: {  user_swipecard: '123456789' }
 
-    assert_response 404
+    assert_response :not_found
   end
 end