Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop-rspec 2.31.0 → 3.0.5 (major) #517

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Sep 8, 2024

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rspec (2.31.0 → 3.0.5) · Repo · Changelog

Release Notes

3.0.5

  • Fix false-negative and error for RSpec/MetadataStyle when non-literal args are used in metadata in EnforceStyle: hash. (@cbliard)
  • Improve offense message for RSpec/IndexedLet. (@earlopain)

3.0.4

  • Fix false-negative for UnspecifiedException when matcher is chained. (@r7kamura)

3.0.3

  • Add support for Unicode RIGHT SINGLE QUOTATION MARK in RSpec/ExampleWording. (@jdufresne)
  • Suppress deprecation warning for RSpec/MultipleExpectations, RSpec/MultipleMemoizedHelpers, and RSpec/NestedGroups cops. (@koic)

3.0.2

  • Fix wrong autocorrect for RSpec/ScatteredSetup when hook contains heredoc. (@earlopain)
  • Fix false negative for RSpec/PredicateMatcher when expectation contains custom failure message. (@earlopain)
  • Facilitate the 3.0 upgrade flow with proper extracted cop messages. (@jeppester)

3.0.1

  • Bump RuboCop requirement to +1.61. (@ydah)

3.0.0

  • Remove extracted cops in Capybara, FactoryBot and Rails departments. (@ydah)
  • Remove RuboCop::RSpec::Language::NodePattern. (@ydah)
  • Remove RSpec/FilePath cop. (@ydah)
  • Remove RSpec/Capybara/FeatureMethods cop. If you are using this cop, change it to use RSpec/Dialect. (@ydah)
  • Add new RSpec/MissingExpectationTargetMethod cop. (@krororo)
  • Fix an error for RSpec/ScatteredSetup when one of the hooks is an empty block. (@earlopain)

These previously pending cops are now enabled by default: RSpec/BeEmpty, RSpec/BeEq, RSpec/BeNil, RSpec/ChangeByZero, RSpec/ClassCheck, RSpec/ContainExactly, RSpec/DuplicatedMetadata, RSpec/EmptyMetadata, RSpec/EmptyOutput, RSpec/Eq, RSpec/ExcessiveDocstringSpacing, RSpec/ExpectInLet, RSpec/IdenticalEqualityAssertion, RSpec/IndexedLet, RSpec/IsExpectedSpecify, RSpec/MatchArray, RSpec/MetadataStyle, RSpec/NoExpectationExample, RSpec/PendingWithoutReason, RSpec/ReceiveMessages, RSpec/RedundantAround, RSpec/RedundantPredicateMatcher, RSpec/RemoveConst, RSpec/RepeatedSubjectCall, RSpec/SkipBlockInsideExample, RSpec/SortMetadata, RSpec/SpecFilePathFormat, RSpec/SpecFilePathSuffix, RSpec/SubjectDeclaration, RSpec/UndescriptiveLiteralsDescription, and RSpec/VerifiedDoubleReference.

Read more about how to upgrade in https://docs.rubocop.org/rubocop-rspec/upgrade_to_version_3.html

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🗑️ rubocop-capybara (removed)

🗑️ rubocop-factory_bot (removed)

🗑️ rubocop-rspec_rails (removed)


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu cancel merge
Cancels automatic merging of this PR
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@depfu depfu bot added dependencies Pull requests that update a dependency file Technical Debt labels Sep 8, 2024
@stevieing
Copy link
Contributor

@depfu rebase

@depfu depfu bot force-pushed the depfu/update/rubocop-rspec-3.0.5 branch from 9a671f5 to f51cc95 Compare September 20, 2024 14:34
@stevieing stevieing merged commit b98774c into develop Sep 20, 2024
2 checks passed
@stevieing stevieing deleted the depfu/update/rubocop-rspec-3.0.5 branch September 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Technical Debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant