Update rubocop 1.56.0 → 1.58.0 (minor) #439

depfu · 2023-12-02T19:20:20Z

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (1.56.0 → 1.58.0) · Repo · Changelog

Release Notes

1.58.0

New features

#12420: Add new Lint/LiteralAssignmentInCondition cop. (@koic)

#12353: Add new Style/SuperWithArgsParentheses cop. (@koic)

#12406: Add new Style/ArrayFirstLast cop. (@fatkodima)

Bug fixes

#12372: Fix a false negative for Lint/Debugger when used within method arguments a begin...end block. (@koic)

#12378: Fix a false negative for Style/Semicolon when a semicolon at the beginning of a lambda block. (@koic)

#12146: Fix a false positive for Lint/FloatComparison when comparing against zero. (@earlopain)

#12404: Fix a false positive for Layout/RescueEnsureAlignment when aligned rescue in do-end numbered block in a method. (@koic)

#12374: Fix a false positive for Layout/SpaceBeforeSemicolon when a space between an opening lambda brace and a semicolon. (@koic)

#12326: Fix an error for Style/RedundantDoubleSplatHashBraces when method call for parenthesized no hash double double splat. (@koic)

#12361: Fix an incorrect autocorrect for Naming/BlockForwarding and Style/ArgumentsForwarding when autocorrection conflicts for anonymous arguments. (@koic)

#12324: Fix an error for Layout/RescueEnsureAlignment when using rescue in do...end block assigned to object attribute. (@koic)

#12322: Fix an error for Style/CombinableLoops when looping over the same data for the third consecutive time or more. (@koic)

#12366: Fix a false negative for Layout/ExtraSpacing when a file has exactly two comments. (@eugeneius)

#12373: Fix a false negative for Lint/SymbolConversion when using string interpolation. (@earlopain)

#12402: Fix false negatives for Style/RedundantLineContinuation when redundant line continuations for a block are used, especially without parentheses around first argument. (@koic)

#12311: Fix false negatives for Style/RedundantParentheses when parentheses around logical operator keywords in method definition. (@koic)

#12394: Fix false negatives for Style/RedundantReturn when lambda (->) ending with return. (@koic)

#12377: Fix false positives for Lint/Void when a collection literal that includes non-literal elements in a method definition. (@koic)

#12407: Fix an incorrect autocorrect for Style/MapToHash with Layout/SingleLineBlockChain. (@koic)

#12409: Fix an incorrect autocorrect for Lint/SafeNavigationChain when ordinary method chain exists after safe navigation leading dot method call. (@koic)

#12363: Fix incorrect rendering of HTML character entities in HTMLFormatter formatter. (@koic)

#12424: Make Style/HashEachMethods aware of safe navigation operator. (@koic)

#12413: Make Style/InverseMethods aware of safe navigation operator. (@koic)

#12408: Make Style/MapToHash aware of safe navigation operator. (@koic)

Changes

#12328: Make Style/AutoResourceCleanup aware of Tempfile.open. (@koic)

#12412: Enhance Lint/RedundantSafeNavigation to handle conversion methods with defaults. (@fatkodima)

#12410: Enhance Lint/SelfAssignment to check attribute assignment and key assignment. (@fatkodima)

#12370: Make Style/HashEachMethods aware of unused block value. (@koic)

#12380: Make Style/RedundantParentheses aware of lambda or proc. (@koic)

#12421: Make Style/SelfAssignment aware of %, ^, <<, and >> operators. (@koic)

#12305: Require rubocop-ast version 1.30 or greater. (@sambostock)

#12337: Supports EnforcedStyleForRationalLiterals option for Layout/SpaceAroundOperators. (@koic)

#12296: Support RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, and RedundantBlockArgumentNames options for Style/ArgumentsForwarding. (@koic)

1.57.2

Bug fixes

#12274: Fix a false positive for Lint/Void when each's receiver is an object of Enumerator to which filter has been applied. (@koic)

#12291: Fix a false positive for Metrics/ClassLength when a class with a singleton class definition. (@koic)

#12293: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge and method chain. (@koic)

#12298: Fix a false positive for Style/RedundantParentheses when using a parenthesized hash literal as the first argument in a method call without parentheses. (@koic)

#12283: Fix an error for Style/SingleLineDoEndBlock when using single line do...end with no body. (@koic)

#12312: Fix an incorrect autocorrect for Style/HashSyntax when braced hash key and value are the same and it is used in if...else. (@koic)

#12307: Fix an infinite loop error for Layout/EndAlignment when EnforcedStyleAlignWith: variable and using a conditional statement in a method argument on the same line and end with method call is not aligned. (@koic)

#11652: Make --auto-gen-config generate inherit_from correctly inside ERB if. (@jonas054)

#12310: Drop base64 gem from runtime dependency. (@koic)

#12300: Fix an error for Style/IdenticalConditionalBranches when if...else with identical leading lines and using index assign. (@koic)

#12286: Fix false positives for Style/RedundantDoubleSplatHashBraces when using double splat with a hash literal enclosed in parenthesized ternary operator. (@koic)

#12279: Fix false positives for Lint/EmptyConditionalBody when missing 2nd if body with a comment. (@koic)

#12275: Fix a false positive for Style/RedundantDoubleSplatHashBraces when using double splat within block argument containing a hash literal in an array literal. (@koic)

#12284: Fix false positives for Style/SingleArgumentDig when using some anonymous argument syntax. (@koic)

#12301: Make Style/RedundantFilterChain aware of safe navigation operator. (@koic)

1.57.1

Bug fixes

#12271: Fix a false positive for Lint/RedundantSafeNavigation when using snake case constant receiver. (@koic)

#12265: Fix an error for Layout/MultilineMethodCallIndentation when usingarithmetic operation with block inside a grouped expression. (@koic)

#12177: Fix an incorrect autocorrect for Style/RedundantException. (@ydah)

#12261: Fix an infinite loop for Layout/MultilineMethodCallIndentation when multiline method chain with a block argument and method chain. (@ydah)

#12263: Fix false positives for Style/RedundantDoubleSplatHashBraces when method call for no hash braced double splat receiver. (@koic)

#12262: Fix an incorrect autocorrect for Style/RedundantDoubleSplatHashBraces when using double splat hash braces with merge method call twice. (@koic)

1.57.0

New features

#12227: Add new Style/SingleLineDoEndBlock cop. (@koic)

#12246: Make Lint/RedundantSafeNavigation aware of constant receiver. (@koic)

#12257: Make Style/RedundantDoubleSplatHashBraces aware of merge methods. (@koic)

Bug fixes

#12244: Fix a false negative for Lint/Debugger when using debugger method inside block. (@koic)

#12231: Fix a false negative for Metrics/ModuleLength when defining a singleton class in a module. (@koic)

#12249: Fix a false positive Style/IdenticalConditionalBranches when if..else with identical leading lines and assign to condition value. (@koic)

#12253: Fix Lint/LiteralInInterpolation to accept an empty string literal interpolated in words literal. (@knu)

#12198: Fix an error for flip-flop with beginless or endless ranges. (@koic)

#12259: Fix an error for Lint/MixedCaseRange when using nested character class in regexp. (@koic)

#12237: Fix an error for Style/NestedTernaryOperator when a ternary operator has a nested ternary operator within an if. (@koic)

#12228: Fix false negatives for Style/MultilineBlockChain when using multiline block chain with safe navigation operator. (@koic)

#12247: Fix false negatives for Style/RedundantParentheses when using logical or comparison expressions with redundant parentheses. (@koic)

#12226: Fix false positives for Layout/MultilineMethodCallIndentation when aligning methods in multiline block chain. (@koic)

#12076: Fixed an issue where the top-level cache folder was named differently during two consecutive rubocop runs. (@K-S-A)

Changes

#12235: Enable auto parallel inspection when config file is specified. (@aboutNisblee)

#12234: Enhance Style/FormatString's autocorrection when using known conversion methods whose return value is not an array. (@koic)

#12128: Make Style/GuardClause aware of define_method. (@koic)

#12126: Make Style/RedundantFilterChain aware of select.present? when ActiveSupportExtensionsEnabled config is true. (@koic)

#12250: Mark Lint/RedundantRequireStatement as unsafe autocorrect. (@koic)

#12097: Mark unsafe autocorrect for Style/ClassEqualityComparison. (@koic)

#12210: Mark Style/RedundantFilterChain as unsafe autocorrect. (@koic)

1.56.4

Bug fixes

#12221: Fix a false positive for Layout/EmptyLineAfterGuardClause when using return before guard condition with heredoc. (@koic)

#12213: Fix a false positive for Lint/OrderedMagicComments when comment text # encoding: ISO-8859-1 is embedded within example code as source code comment. (@koic)

#12205: Fix an error for Style/OperatorMethodCall when using foo bar./ baz. (@koic)

#12208: Fix an incorrect autocorrect for the --disable-uncorrectable command line option when registering an offense is outside a percent array. (@koic)

#12203: Fix an incorrect autocorrect for Lint/SafeNavigationChain when using safe navigation with comparison operator as an expression of logical operator or comparison operator's operand. (@koic)

#12206: Fix an incorrect autocorrect for Style/OperatorMethodCall when using foo./bar. (@koic)

#12202: Fix an incorrect autocorrect for Style/RedundantConditional when unless/else with boolean results. (@ydah)

#12199: Fix false negatives for Layout/MultilineMethodCallIndentation when using safe navigation operator. (@koic)

Changes

#12197: Make Style/CollectionMethods aware of collect_concat. (@koic)

1.56.3

Bug fixes

#12151: Make Layout/EmptyLineAfterGuardClause allow :nocov: directive after guard clause. (@koic)

#12195: Fix a false negative for Layout/SpaceAfterNot when a newline is present after !. (@ymap)

#12192: Fix a false positive for Layout/RedundantLineBreak when using quoted symbols with a single newline. (@ymap)

#12190: Fix a false positive for Layout/SpaceAroundOperators when aligning operators vertically. (@koic)

#12171: Fix a false positive for Style/ArrayIntersect when using block argument for Enumerable#any?. (@koic)

#12172: Fix a false positive for Style/EmptyCaseCondition when using return, break, next or method call before empty case condition. (@koic)

#12162: Fix an error for Bundler/DuplicatedGroup when there's a duplicate set of groups and the group value contains a splat. (@koic)

#12182: Fix an error for Lint/UselessAssignment when variables are assigned using chained assignment and remain unreferenced. (@koic)

#12181: Fix an incorrect autocorrect for Lint/UselessAssignment when variables are assigned with sequential assignment using the comma operator and unreferenced. (@koic)

#12187: Fix an incorrect autocorrect for Style/SoleNestedConditional when comment is in an empty nested if body. (@ymap)

#12183: Fix an incorrect autocorrect for Style/MultilineTernaryOperator when returning a multiline ternary operator expression with safe navigation method call. (@koic)

#12168: Fix bug in Style/ArgumentsForwarding when there are repeated send nodes. (@owst)

#12185: Set target version for Layout/HeredocIndentation. (@tagliala)

1.56.2

Bug fixes

#12138: Fix a false positive for Layout/LineContinuationLeadingSpace when a backslash is part of a multiline string literal. (@ymap)

#12155: Fix false positive for Layout/RedundantLineBreak when using a modified singleton method definition. (@koic)

#12143: Fix a false positive for Lint/ToEnumArguments when using anonymous keyword arguments forwarding. (@koic)

#12148: Fix an incorrect autocorrect for Lint/NonAtomicFileOperation when using FileUtils.remove_dir, FileUtils.remove_entry, or FileUtils.remove_entry_secure. (@koic)

#12141: Fix false positive for Style/ArgumentsForwarding when method def includes additional kwargs. (@owst)

#12154: Fix incorrect diagnosticProvider value of LSP. (@koic)

1.56.1

Bug fixes

#12136: Fix a false negative for Layout/LeadingCommentSpace when using #+ or #- as they are not RDoc comments. (@koic)

#12113: Fix a false positive for Bundler/DuplicatedGroup when groups are duplicated but source, git, platforms, or path values are different. (@koic)

#12134: Fix a false positive for Style/MethodCallWithArgsParentheses when parentheses are used in one-line in pattern matching. (@koic)

#12111: Fix an error for Bundler/DuplicatedGroup group declaration has keyword option. (@koic)

#12109: Fix an error for Style/ArgumentsForwarding cop when forwarding kwargs/block arg and an additional arg. (@ydah)

#12117: Fix a false positive for Style/ArgumentsForwarding cop when not always forwarding block. (@owst)

#12115: Fix an error for Style/Lambda when using numbered parameter with a multiline -> call. (@koic)

#12124: Fix false positives for Style/RedundantParentheses when parentheses in super or yield call with multiline style argument. (@koic)

#12120: Fix false positives for Style/SymbolArray when %i array containing unescaped [, ], (, or ). (@koic)

#12133: Fix Style/RedundantSelfAssignmentBranch to handle heredocs. (@r7kamura)

#12105: Fix target ruby Gem::Requirement matcher and version parsing to support multiple version constraints. (@ItsEcholot)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ json (indirect, 2.6.3 → 2.7.0) · Repo · Changelog

Release Notes

2.7.0

What's Changed

Improved

Perf. improvements to Hash#to_json in pure implementation generator. by @vipulnsward in #203

Remove unnecessary initialization of create_id in JSON.parse() by @Watson1978 in #454

Added

Call super in included hook by @paracycle in #486

Rename escape_slash in script_safe and also escape E+2028 and E+2029 by @casperisfine in #525

Add a strict option to Generator by @casperisfine in #519

Fixed

Fix homepage url in gemspec by @unasuke in #508

Fix dead link to Ragel in README by @okuramasafumi in #509

[DOC] Fix yet another dead link to Ragel by @nobu in #510

Fix "unexpected token" offset for Infinity by @jhawthorn in #507

Use ruby_xfree to free buffers by @casperisfine in #518

Compatibility changes

JRuby requires a minimum of Java 8 by @headius in #516

Rename JSON::ParseError to JSON:ParserError by @dalizard in #530

Removed code for Ruby 1.8 by @hsbt in #540

alias_method is private on Ruby 2.3 and 2.4 by @hsbt in #541

remove_method of Module is private at Ruby 2.3 and 2.4 by @hsbt in #544

[jruby] avoid using deprecated BigDecimal.new by @kares in #546

Always indent even if empty by @headius in #517

Misc

Update CI matrix by @hsbt in #521

Add missing changelog entries for 1.8.5 and 1.8.6 by @r7kamura in #520

Actions workflow - Add new OS's, Ruby 3.1, Ruby master, Windows by @MSP-Greg in #491

Skip unsupported test on JRuby by @nobu in #532

Skip BigDecimal tests when it's missing to load by @hsbt in #533

Simplify by @nobu in #531

Load extension ('json/ext') consistently in test_ext by @aeroastro in #536

Use test-unit-ruby-core gem by @hsbt in #539

[CI] Add Windows mswin job by @MSP-Greg in #545

Exclude truffleruby-head from Actions by @hsbt in #551

tests/ractor_test.rb: make assert_separately available by @lucaskanashiro in #506

Added changes for 2.7.0 and restore entries to 2.6.3 and 2.6.2 by @hsbt in #552

New Contributors

@unasuke made their first contribution in #508

@okuramasafumi made their first contribution in #509

@r7kamura made their first contribution in #520

@MSP-Greg made their first contribution in #491

@paracycle made their first contribution in #486

@dalizard made their first contribution in #530

@aeroastro made their first contribution in #536

@jhawthorn made their first contribution in #507

@lucaskanashiro made their first contribution in #506

@Watson1978 made their first contribution in #454

Full Changelog: v2.6.3...v2.7.0

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ parser (indirect, 3.2.2.3 → 3.2.2.4) · Repo · Changelog

Release Notes

3.2.2.4 (from changelog)

API modifications:

bump Racc to 1.7.1 (#930) (Koichi ITO)

Bugs fixed:

Fix an error for flip-flop with beginless or endless ranges (#946) (Koichi ITO)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ racc (indirect, 1.7.1 → 1.7.3) · Repo · Changelog

Release Notes

1.7.3

What's Changed

Exclude CRuby extension from JRuby gem by @nobu in #244

Fix for dummy rake/extensiontask.rb at ruby test-bundled-gems by @nobu in #245

Fix jar file path by @nobu in #246

Bump by @nobu in #247

Add srcs target to prepare to build by @nobu in #248

Make CI runnable for any push by @yui-knk in #249

Check rake build on CI by @yui-knk in #250

Bump up v1.7.3.pre.1 by @yui-knk in #251

Fix locations of expect param in docs by @yui-knk in #252

'lib/racc/parser-text.rb' depends on 'lib/racc/info.rb' by @yui-knk in #253

Bump up v1.7.3 by @yui-knk in #254

Full Changelog: v1.7.2...v1.7.3

1.7.2

What's Changed

Update parser.rb, fixed typo by @jwillemsen in #224

Remove leading newline from on_error exception messages. by @zenspider in #226

Add --frozen to add frozen_string_literals to top of generated files. by @zenspider in #225

Update development dependency to avoid ruby 2.5 failures by @flavorjones in #228

dep: pin development dependencies, and enable dependabot for gems by @flavorjones in #229

Clean embedded pragmas by @nobu in #230

Embed grammar file name into generated file by @yui-knk in #231

Bump actions/checkout from 3 to 4 by @dependabot in #232

Fix a typo by @yui-knk in #234

Add "Release flow" to README.rdoc by @yui-knk in #235

Prepare 1.7.2 by @nobu in #236

Remove install guide by setup.rb by @yui-knk in #237

Fix tiny typos by @makenowjust in #238

Remove old checks by @nobu in #240

Remove MANIFEST which was used by ancient extmk.rb by @nobu in #242

Extract Racc::VERSION from racc/info.rb at extconf.rb by @nobu in #241

Use prototype declarations by @nobu in #243

Bump up v1.7.2 by @yui-knk in #239

New Contributors

@makenowjust made their first contribution in #238

Full Changelog: v1.7.1...v1.7.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ regexp_parser (indirect, 2.8.1 → 2.8.2) · Repo · Changelog

Release Notes

2.8.2 (from changelog)

Fixed

handle a corner case where parsing redundant number escapes raised an error

e.g. parse(/\99/), which in Ruby is a valid Regexp that matches 99

thanks to Markus Schirp for the report

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ rubocop-ast (indirect, 1.29.0 → 1.30.0) · Repo · Changelog

Release Notes

1.30.0 (from changelog)

New features

#270: Add BlockNode#{first,last}_argument helpers. (@sambostock)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

Release Notes

2.5.0 (from changelog)

Unicode 15.1

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.

🗑️ base64 (removed)

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@depfu rebase
Rebases against your default branch and redoes this update

@depfu recreate
Recreates this PR, overwriting any edits that you've made to it

@depfu merge
Merges this PR once your tests are passing and conflicts are resolved

@depfu cancel merge
Cancels automatic merging of this PR

@depfu close
Closes this PR and deletes the branch

@depfu reopen
Restores the branch and reopens this PR (if it's closed)

@depfu pause
Ignores all future updates for this dependency and closes this PR

@depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR

@depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

depfu · 2023-12-12T19:33:39Z

Closed in favor of #441.

depfu · 2023-12-12T19:33:48Z

Closed in favor of #441.

Update rubocop to version 1.58.0

b12f703

depfu bot added the depfu label Dec 2, 2023

depfu bot mentioned this pull request Dec 2, 2023

Update rubocop 1.56.0 → 1.57.2 (minor) #434

Closed

depfu bot closed this Dec 12, 2023

depfu bot deleted the depfu/update/rubocop-1.58.0 branch December 12, 2023 19:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update rubocop 1.56.0 → 1.58.0 (minor) #439

Update rubocop 1.56.0 → 1.58.0 (minor) #439

depfu bot commented Dec 2, 2023

depfu bot commented Dec 12, 2023

depfu bot commented Dec 12, 2023

Update rubocop 1.56.0 → 1.58.0 (minor) #439

Update rubocop 1.56.0 → 1.58.0 (minor) #439

Conversation

depfu bot commented Dec 2, 2023

What changed?

✳️ rubocop (1.56.0 → 1.58.0) · Repo · Changelog

New features

Bug fixes

Changes

Bug fixes

Bug fixes

New features

Bug fixes

Changes

Bug fixes

Changes

Bug fixes

Bug fixes

Bug fixes

↗️ json (indirect, 2.6.3 → 2.7.0) · Repo · Changelog

What's Changed

Improved

Added

Fixed

Compatibility changes

Misc

New Contributors

↗️ parser (indirect, 3.2.2.3 → 3.2.2.4) · Repo · Changelog

3.2.2.4 (from changelog)

↗️ racc (indirect, 1.7.1 → 1.7.3) · Repo · Changelog

What's Changed

What's Changed

New Contributors

↗️ regexp_parser (indirect, 2.8.1 → 2.8.2) · Repo · Changelog

2.8.2 (from changelog)

↗️ rubocop-ast (indirect, 1.29.0 → 1.30.0) · Repo · Changelog

1.30.0 (from changelog)

↗️ unicode-display_width (indirect, 2.4.2 → 2.5.0) · Repo · Changelog

2.5.0 (from changelog)

🗑️ base64 (removed)

depfu bot commented Dec 12, 2023

depfu bot commented Dec 12, 2023