Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix string comparison #283

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Bugfix string comparison #283

merged 5 commits into from
Mar 16, 2021

Conversation

emrojo
Copy link
Contributor

@emrojo emrojo commented Mar 15, 2021 •
edited by harrietc52
Loading

Hot fix - not writing pickable wells in DART because of string equality check bug
@pjvv How do we go about updating the release version?

@emrojo emrojo linked an issue Mar 15, 2021 that may be closed by this pull request
GPL-922 BUG - Release of priority samples was not setting pickable wells in dart #282
Open
@codecov
Copy link

codecov bot commented Mar 15, 2021 •
edited
Loading

Codecov Report

Merging #283 (bd52e86) into master (f2325fe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          33       33           
  Lines        2361     2361           
  Branches      278      278           
=======================================
  Hits         2152     2152           
  Misses        164      164           
  Partials       45       45
Impacted Files Coverage Δ
crawler/helpers/general_helpers.py 85.18% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2325fe...bd52e86. Read the comment docs.

@harrietc52 harrietc52 marked this pull request as ready for review March 15, 2021 17:14
@harrietc52 harrietc52 changed the base branch from develop to master March 15, 2021 17:16
@harrietc52 harrietc52 requested a review from pjvv March 15, 2021 17:17
pjvv
pjvv previously approved these changes Mar 15, 2021
View reviewed changes
tests/test_file_processing.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@pjvv
Copy link
Contributor

pjvv commented Mar 15, 2021

All you need to do is increment the .release_version file with the appropriate number - this is a bug fix so just update the patch.

@harrietc52 harrietc52 requested a review from pjvv March 16, 2021 10:38
@emrojo emrojo merged commit e44521b into master Mar 16, 2021
@emrojo emrojo deleted the bugfix_string_comparison branch March 16, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjvv pjvv pjvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPL-922 BUG - Release of priority samples was not setting pickable wells in dart
3 participants
@emrojo @pjvv @harrietc52