Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anaconda purge #29

Merged
merged 16 commits into from
Dec 5, 2024
Merged

Anaconda purge #29

merged 16 commits into from
Dec 5, 2024

Conversation

tkchafin
Copy link
Contributor

@tkchafin tkchafin commented Dec 2, 2024

  • nf-core module updates
  • changes python version in samplesheet_check (3 defaults packages)
  • removed anaconda references in various files

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@tkchafin tkchafin requested a review from muffato December 2, 2024 18:20
Copy link

github-actions bot commented Dec 2, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a6630a9

+| ✅ 130 tests passed       |+
#| ❔  22 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: assets/nf-core-sequencecomposition_logo_light.png
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: docs/images/nf-core-sequencecomposition_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-sequencecomposition_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-sequencecomposition_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-sequencecomposition_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-sequencecomposition_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/sequencecomposition/sequencecomposition/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2024-12-05 21:01:56

Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Like in [https://github.com/sanger-tol/insdcdownload/pull/23#issuecomment-2517577460] you can adjust a couple of things to make this a PR directly ready for release.

@tkchafin tkchafin changed the base branch from dev to patch December 5, 2024 17:27
@muffato
Copy link
Member

muffato commented Dec 5, 2024

Oh, I've realised something: there was a bunch of changes on dev not yet merged into main. We're therefore actually talking here of a new release, 1.1.0, rather a 1.0.1 patch release. I'm changing the base branch back to dev.

@muffato muffato changed the base branch from patch to dev December 5, 2024 20:24
Copy link
Member

@muffato muffato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the CHANGELOG etc. Take a look but I think that covers everything from dev.

By the way, I had actually named 1.0.0 "Apophis", cf the Zenodo record.
You may not be a fan of Stargate SG1 or the ancient Egypt ;) Don't need to stick with that nomenclature. I've left Polite Platyfish for v1.1

@tkchafin tkchafin merged commit 7a40e2b into sanger-tol:dev Dec 5, 2024
4 of 6 checks passed
@tkchafin tkchafin deleted the anaconda_purge branch December 5, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants