-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anaconda purge #29
Anaconda purge #29
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Like in [https://github.com/sanger-tol/insdcdownload/pull/23#issuecomment-2517577460] you can adjust a couple of things to make this a PR directly ready for release.
Oh, I've realised something: there was a bunch of changes on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the CHANGELOG etc. Take a look but I think that covers everything from dev
.
By the way, I had actually named 1.0.0 "Apophis", cf the Zenodo record.
You may not be a fan of Stargate SG1 or the ancient Egypt ;) Don't need to stick with that nomenclature. I've left Polite Platyfish for v1.1
PR checklist
nf-core lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).