Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple output options #64

Closed
priyanka-surana opened this issue Mar 16, 2023 · 1 comment · Fixed by #107
Closed

Add multiple output options #64

priyanka-surana opened this issue Mar 16, 2023 · 1 comment · Fixed by #107
Assignees
Labels
enhancement Improvement of the existing features user request Requests made by users and public
Milestone

Comments

@priyanka-surana
Copy link
Contributor

priyanka-surana commented Mar 16, 2023

Description of feature

To close this issue:

  1. Add a new parameter --outfmt which takes values bam or cram, and a new parameter --compression which takes values none or crumble. User can pass multiple options separated by a ,.
  2. In the main workflow or the input_check sub-workflow, parse and validate the parameter values, and pass these to the convert_stats sub-workflow.
  3. Configure the convert_stats sub-workflow to only run CRUMBLE if --compression crumble is passed, and to only run SAMTOOLS_VIEW if --outfmt cram is passed.
  4. Run tests to make sure --outfmt works as expected.
  5. Update the documentation.
@priyanka-surana priyanka-surana added the enhancement Improvement of the existing features label Mar 16, 2023
@priyanka-surana priyanka-surana added this to the 1.2.0 milestone Mar 16, 2023
@priyanka-surana priyanka-surana self-assigned this Mar 16, 2023
@priyanka-surana priyanka-surana pinned this issue Mar 16, 2023
@muffato
Copy link
Member

muffato commented Mar 17, 2023

crumble works on BAM files too, so the choices are 1) BAM vs CRAM, 2) original scores vs compressed scores (crumble)

@priyanka-surana priyanka-surana added the feature Requests for new features label Jun 27, 2023
@priyanka-surana priyanka-surana added the user request Requests made by users and public label Jun 27, 2023
@priyanka-surana priyanka-surana linked a pull request Jul 11, 2023 that will close this issue
@muffato muffato moved this from Todo to In Progress in Genome After Party Nov 10, 2023
@muffato muffato removed this from the 1.2.0 milestone Dec 8, 2023
@muffato muffato added this to the 1.3.0 milestone Feb 12, 2024
@muffato muffato self-assigned this Jun 1, 2024
@muffato muffato removed the enhancement Improvement of the existing features label Jun 1, 2024
@muffato muffato moved this to To do in readmapping Jun 5, 2024
@muffato muffato removed their assignment Jun 5, 2024
@muffato muffato moved this from In Progress to Todo in Genome After Party Jun 6, 2024
@muffato muffato mentioned this issue Jun 6, 2024
9 tasks
@muffato muffato added enhancement Improvement of the existing features and removed feature Requests for new features labels Jun 17, 2024
@muffato muffato removed this from the 1.3.0 milestone Jul 12, 2024
@tkchafin tkchafin moved this from Todo to In Progress in Genome After Party Jul 22, 2024
@tkchafin tkchafin moved this from To do to In Progress in readmapping Jul 22, 2024
@tkchafin tkchafin self-assigned this Aug 14, 2024
@tkchafin tkchafin linked a pull request Aug 14, 2024 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Genome After Party Aug 19, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in readmapping Aug 19, 2024
@muffato muffato unpinned this issue Aug 22, 2024
@muffato muffato added this to the 1.3.0 milestone Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of the existing features user request Requests made by users and public
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants