refact: Add suggestions from the third round of reviews #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
* wip: Add bug two * refact: Try defaulting to a dict * fix: Dont allow remote to be unbound * refact: Check if not equal to component type * refact: Re-add isinstance dict * fix: Remove mention of component_name * refact: Add special case for strings following dicts * test: Try removing branch from test case * refact: Remove isinstance for str * refact: Use dict only with get_comps out * Revert "refact: Use dict only with get_comps out" This reverts commit 7ebc6dc. * refact: Check if content has subwfs * refact: Always set current remote * refact: Check sha before resetting current_repo * refact: Do the negative test * refact: Use another variable for remote * refact: Simplify check * refact: Expand check once again * refact: Roll back to previous check * fix: self.sha must not be none to reset to none * Revert "fix: self.sha must not be none to reset to none" This reverts commit 65aa1c4. * Try removing the section entirely * refact: Try moving check to reset * refact: Remove unnecessary current_sha * refact: Change check in get_comps * refact: Set git remote beforehand * refact: Change indent so previous check is the same * refact: Remove current repo check * Revert "refact: Remove current repo check" This reverts commit a956e04. * refact: Try using name list * fix: Remove break in loop * refactor: Always set current_repo * fix: Check if name is in updated * refactor: Remove unused sections and logs
get_genome_annotation is not necessary, given we're using another subworkflow for the other tests
|
The two failing test cases are - I believe - unrelated to the feature, and will probably fix themselves once I merge the upstream changes to the fix/1927 branch |
muffato
reviewed
Dec 1, 2024
muffato
approved these changes
Dec 4, 2024
muffato
added this to the Enable subworkflows with cross-organization modules milestone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds suggestions from the third round of reviews
PR checklist
CHANGELOG.mdis updateddocsis updated