feat: load google maps api dynamically #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sandydoo Another one 🙏 |
sandydoo
requested changes
Apr 5, 2024
| @@ -71,19 +71,57 @@ Learn more: https://ember-google-maps.sandydoo.me/docs/getting-started`, | |||
| ); | |||
|
|
|||
| return new Promise((resolve, reject) => { | |||
| window.initGoogleMap = bind(() => { | |||
| const params = new URLSearchParams(new URL(src).search); | |||
There was a problem hiding this comment.
- I would use the
configdirectly at this point. I don't see a need to use URI-escaped values here. - As an option, we could also do something
JSON.stringify(Object.fromEntries([["version", "whatever"], ["emptyOption", ""]].filter((_, x) => x))). Or push to an array of options, thenjoin(','). I don't really have a preference here, just worried about forgetting a comma somewhere. - Are there versions of google maps that are still available, but don't support this? Should there be a version check to fall back to loading from
src?
|
Closing in favour of #193 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loads the maps api dynamically as is the recommended way.
I tried to make sure the diff in the PR is as minimal as possible 😉