This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
feat: improve types #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
withLoginRequired and withAuth weren't typed properly. Their parameters required ClassComponents. Using FunctionalComponents weren't possible previously. This commit changes their parameters to ComponentType. It accepts class components and function components. Returned values are typed properly too. withAuth returns same component type that was passed as a param. withLoginRequired adds optional path property.
|
We would love this feature :) |
|
+1 @sandrinodimattia Can we have this merged, please? It would save me from quite some ugly typecasting... |
|
For anyone looking for a short-term solution until the pull request is (hopefully) merged, attached is a patch file to be used with patch-package. |
|
@sandrinodimattia is there a plan to merge this PR? |
|
This will be really nice to have |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
withLoginRequired and withAuth weren't typed properly. Their parameters
required ClassComponents. Using FunctionalComponents weren't possible
previously. This commit changes their parameters to ComponentType. It accepts
class components and function components.
Returned values are typed properly too. withAuth returns same component type
that was passed as a param. withLoginRequired adds optional path property.