Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(driver): doc string if not found returns blank. If multiple, tak… #238

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(driver): doc string if not found returns blank. If multiple, tak… #238

wants to merge 2 commits into from

Conversation

i-am-mounce
Copy link
Collaborator

…es first

@i-am-mounce i-am-mounce reopened this Nov 18, 2024
mplilly4395
mplilly4395 reviewed Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@mplilly4395 mplilly4395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we look for additional lines in the doc with len(doc_string)? It works because doc_string is long, and the code goes through a few lines, but it seems like the logic is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplilly4395 mplilly4395 mplilly4395 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-am-mounce @mplilly4395 @ammounce