Skip to content

Commit

Permalink
[py] Moved Rust binary settings to pyproject.toml from setup.py (S…
Browse files Browse the repository at this point in the history
…eleniumHQ#14837)

* Moved Rust binary settings to pyproject.toml from setup.py
* Update Rakefile to remove py/setup.py

---------

Co-authored-by: Viet Nguyen Duc <[email protected]>
  • Loading branch information
sandeepsuryaprasad and VietND96 authored Dec 5, 2024
1 parent 875f0a6 commit 30cf1bc
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 43 deletions.
5 changes: 1 addition & 4 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -585,8 +585,7 @@ namespace :py do
nightly = ".#{Time.now.strftime('%Y%m%d%H%M')}"
new_version = updated_version(old_version, arguments[:version], nightly)

['py/setup.py',
'py/pyproject.toml',
['py/pyproject.toml',
'py/BUILD.bazel',
'py/selenium/__init__.py',
'py/selenium/webdriver/__init__.py',
Expand Down Expand Up @@ -1048,7 +1047,6 @@ namespace :all do
'py/selenium/webdriver/__init__.py',
'py/selenium/__init__.py',
'py/BUILD.bazel',
'py/setup.py',
'rb/lib/selenium/webdriver/version.rb',
'rb/Gemfile.lock'])

Expand Down Expand Up @@ -1110,7 +1108,6 @@ namespace :all do
'py/selenium/webdriver/__init__.py',
'py/BUILD.bazel',
'py/CHANGES',
'py/setup.py',
'rb/lib/selenium/webdriver/version.rb',
'rb/CHANGES',
'rb/Gemfile.lock',
Expand Down
1 change: 0 additions & 1 deletion py/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,6 @@ pkg_files(
"CHANGES",
"README.rst",
"pyproject.toml",
"setup.py",
":license",
":selenium-pkg",
":selenium-pkginfo",
Expand Down
3 changes: 3 additions & 0 deletions py/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ exclude = ["test*"]
namespaces = false
# include-package-data is `true` by default in pyproject.toml

[[tool.setuptools-rust.bins]]
target = "selenium.webdriver.common.selenium-manager"

[project.urls]
Repository = "https://github.com/SeleniumHQ/selenium/"
BugTracker = "https://github.com/SeleniumHQ/selenium/issues"
Expand Down
38 changes: 0 additions & 38 deletions py/setup.py

This file was deleted.

0 comments on commit 30cf1bc

Please sign in to comment.