Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default on LogicState #26

Open
samitbasu opened this issue Jul 1, 2023 · 0 comments
Open

Use default on LogicState #26

samitbasu opened this issue Jul 1, 2023 · 0 comments
Assignees
@samitbasu
Labels
enhancement New feature or request

Comments

@samitbasu
Copy link
Owner

Rust has a way to specify the default value of an enum... Use this.

Currently, a LogicState enum has to default to the first item in the enum. This seems an unnecessary constraint. Better to require that the underlying type implement Default and then allow the user to specify the default state with #[default]. Note that this likely means either more non-zero-init DFFs, or reordering enum assignments.
@samitbasu samitbasu added the enhancement New feature or request label Jul 1, 2023
@samitbasu samitbasu self-assigned this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samitbasu samitbasu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samitbasu