Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some changes to CAT II #4

Merged
merged 14 commits into from
Aug 6, 2016
Merged

Conversation

johannes-cabal
Copy link
Contributor

Hey, didn't have much time left, but started working from the bottom up. Added the CAT II audit file, included in main.yml, and started hitting some items.

Added entry to include CAT II in main.yml and added some audits/patches.
@@ -0,0 +1,25 @@
- name: "MEDIUM | RHEL-07-040640 | AUDIT | The SSH public host key files must have mode 0644 or less permissive."
command: find / -name '*ssh_host*key'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the find module rather than command.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Will commit when finished with other changes.

@johannes-cabal
Copy link
Contributor Author

Yep, will be adding it all in. Mainly wanted to get a commit in to make sure I was following the right styling for stuff.

- Added & Updated Cat II Audit
- Added CAT II Patches
- Added a default item
- Removed rhel7stig_cat1_patch from main.yml (fails on condition), will
correct later
Fixed a label typo.
dest: "{{ item }}"
mode: 0644
state: file
dest: "{{ item }}"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use item.path.

value: 1
sysctl_set: yes
reload: yes
ignore_errors: yes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Created the audit for 040180, 040181, and 04182. Need to get with you to
figure out how we want to handle LDAP key files.
change ntp to ntpd i ntags
- name: "MEDIUM | RHEL-07-040230 | AUDIT | The operating system, if using PKI-based authentication, must implement a local cache of revocation data to certificate validation in case of the inability to access revocation information via the network."
stat:
path: /var/lib/pki-kra/conf/server.xml
register: rhel_07_040230_audit
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add failed_when, changed_when, and ignore_errors to all audit tasks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Fixed with backticks.
# Conflicts:
#	README.md
#	defaults/main.yml
#	handlers/main.yml
@johannes-cabal
Copy link
Contributor Author

Also, I merged our changes together so you shouldn't have to.

@samdoran samdoran merged commit e57e079 into samdoran:devel Aug 6, 2016
samdoran pushed a commit that referenced this pull request Apr 5, 2017
* Started working on CAT II

Added entry to include CAT II in main.yml and added some audits/patches.

* Tweaked formatting on my changes.

* Fix type-o in README

* Update author information

* Made corrective changes to previous commit.

* Spacing...

* Made some updates to audit,main,patch, and defaults

- Added & Updated Cat II Audit
- Added CAT II Patches
- Added a default item
- Removed rhel7stig_cat1_patch from main.yml (fails on condition), will
correct later

* Updated a label.

Fixed a label typo.

* Corrected finding label

* Made fixes with suggestions, added some vars, and a placeholder for cat3 audits.

* Made some slight changes.

Created the audit for 040180, 040181, and 04182. Need to get with you to
figure out how we want to handle LDAP key files.

* Minor text fix (tags)

change ntp to ntpd i ntags

* Made adjustments based on suggestions.

* Updated the README

Fixed with backticks.

* Made some changes to CAT II (#4)

* Started working on CAT II

Added entry to include CAT II in main.yml and added some audits/patches.

* Tweaked formatting on my changes.

* Made corrective changes to previous commit.

* Spacing...

* Made some updates to audit,main,patch, and defaults

- Added & Updated Cat II Audit
- Added CAT II Patches
- Added a default item
- Removed rhel7stig_cat1_patch from main.yml (fails on condition), will
correct later

* Updated a label.

Fixed a label typo.

* Corrected finding label

* Made fixes with suggestions, added some vars, and a placeholder for cat3 audits.

* Made some slight changes.

Created the audit for 040180, 040181, and 04182. Need to get with you to
figure out how we want to handle LDAP key files.

* Minor text fix (tags)

change ntp to ntpd i ntags

* Made adjustments based on suggestions.

* Updated the README

Fixed with backticks.

* Add variable for determing if system is acting as a router.

* Correct variable name used for determing if a windowing graphical environment is in use

* Add RHEL-07-040620

* Correct indentation

* Updated README to reflect the current revision, updates CAT1 STIG ID's, added an un-covered item

* Added temporary STIG checklist for reference. Can be used to compare current repo status in STIG Viewer

* Updated some typos, finished up CATI changes and Variable naming

* Updating STIG ID's, handler name, and checklist

* Re-organizing CAT II findings. Also completed the additional CAT I finding introduced in the release

* Cat 2's are re-org'd, fixed some low-hanging fruit while change the structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants