Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix certificate/key/chain file's group ownerships on BSD Unix #259

Closed
wants to merge 1 commit into from
Closed

Conversation

xenophonf
Copy link
Contributor

The name for GID 0 is different on BSD Unix.

Summary of Changes

  • Added three os_family checks; if they match *BSD, the states use the wheel group instead of root.

Testing

  • Tested on FreeBSD 11.2-RELEASE
  • Tested on CentOS 7.6.1810

The name for GID 0 is different on BSD Unix.
@myii
Copy link
Member

myii commented Apr 10, 2019

@xenophonf Thanks for this. This closes #258, right?

In terms of the implementation, to avoid the extra Jinja conditionals, couldn't these differences be provided in the osfamilymap?

@xenophonf
Copy link
Contributor Author

Yes, this closes #258. Do you want me to refactor it to use osfamilymap?

@myii
Copy link
Member

myii commented Apr 10, 2019

@xenophonf I believe that's the correct solution but it will require making entries to each OS family. If time is short, I'd have no objections to this being merged as-is. Perhaps adding an issue to remind us to move this to osfamilymap in the long-run.

@xenophonf
Copy link
Contributor Author

We could set the group to root in the defaults and then override it on a per-family basis. That should keep things clean and simple. I'll take a look at it after work tonight.

@alxwr alxwr self-assigned this Apr 23, 2019
@alxwr
Copy link
Member

alxwr commented Apr 23, 2019

I'll take a look at it after work tonight.
(13 days later...)

I feel your pain. :-D

I'd vote for osfamilymap too.

@noelmcloughlin
Copy link
Member

Fixed in #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants