Fix missing options in htmlbars-ast-plugin #177
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #166
The problem is as follows: When using ember-css-modules in an ember-addon, the options are added in the
included
function of the ember-addon, and is therefore not available whensetupPreprocessorRegistry
of ember-css-modules is run. So the htmlbars-ast-plugin did not get the information about virtualModules.This fix uses a bound function instead of an options object. I don't know anything about the ember-cli API, so there is probably a better solution.