Code

[RFC] fixpoint iteration support#603

Code

Open

carljm wants to merge 34 commits intosalsa-rs:mastersalsa-rs/salsa:masterfrom carljm:fixpointcarljm/salsa:fixpointCopy head branch name to clipboard

+1,968-1,503

Commits

Commits on Dec 16, 2024

• add example test for fixpoint iteration

  carljm

  committed
  3d00ae3

• add a multi-symbol test

  carljm

  committed
  31979b9

• simplify test case

  carljm

  committed
  35e236e

• WIP: remove existing cycle handling tests for now

  carljm

  committed
  90ea6e9

• WIP: remove all existing cycle handling, add fixpoint options

  carljm

  committed
  f218e58

• WIP: added provisional value and cycle fields

  carljm

  committed
  6ce61c6

• rename to CycleRecoveryStrategy::Fixpoint

  carljm

  committed
  29d110e

• WIP: rip out ProvisionalValue

  carljm

  committed
  adb6c77

• WIP: working single-iteration with provisional memo

  carljm

  committed
  7f82b6d

• WIP: add count arg to cycle_recovery_fn

  carljm

  committed
  a7be3d9

• WIP: move insert-initial out into fetch_cold

  carljm

  committed
  6c6dd55

• WIP: cycle-head iteration

  carljm

  committed
  8974361

• WIP: move loop into execute

  carljm

  committed
  797655e

• WIP: delay storing memo

  carljm

  committed
  27742a2

• WIP: remove ourself from cycle heads when done iterating

  carljm

  committed
  4f4df72

• WIP: working convergence and fallback

  carljm

  committed
  315944e

• WIP: clippy and cleanup

  carljm

  committed
  28242a4

• WIP: improve comments and add a type annotation

  carljm

  committed
  0be825a

• WIP: don't allow cycle_fn with no_eq

  carljm

  committed
  c3c84c4

• WIP: add tracing for cycle iteration

  carljm

  committed
  72dff5f

• WIP: fail fast if we get an evicted provisional value

  carljm

  committed
  6b44c92

• WIP: use FxHashSet::from_iter

  carljm

  committed
  a029ef4

• add tests, fix multiple-revision, lazy provisional value

  carljm

  committed
  492ae1b

• review feedback, more tracing

  carljm

  committed
  0f7d940

• fix multi-revision bug

  carljm

  committed
  5ef7a5f

• better fix for multi-revision bug

  carljm

  committed
  3093460

• test fixes

  carljm

  committed
  7d9ec1c

• pass inputs to cycle recovery functions

  carljm

  committed
  aa4a731

• fixed cycle-unchanged test

  carljm

  committed
  67376f1

• add TODO comments for some outstanding questions

  carljm

  committed
  286b5fb

• add a test for the "AB peeping C" scenario

  

  Niko Matsakis

  authored and

  carljm

  committed
  b2d4d92

• another parallel test scenario

  

  Niko Matsakis

  authored and

  carljm

  committed
  670f88b

• WIP: removed cycle_ignore; nested cycles broken

  carljm

  committed
  00acc56

Commits on Dec 18, 2024

• fixed all single-thread cycles; multi-thread still not working

  carljm

  committed
  5202579