Skip to content

Commit

Permalink
Skip compile-fail tests on Windows for now
Browse files Browse the repository at this point in the history
These tests need a lot of changes to work on Windows,
so leave them for now. For example, the expected
compiler error message is different (MSVC reports a
C2338 error), include paths often contain spaces which
we don't currently handle, and the command line needs
extra arguments such as /MD to build correctly with Boost.
  • Loading branch information
benmwebb committed Feb 3, 2024
1 parent aeea4f4 commit 196959f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions modules/test/pyext/src/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,8 @@ def _read_cmake_cache(self, cmake_cache):
def assertCompileFails(self, headers, body):
"""Test that the given C++ code fails to compile with a static
assertion."""
if sys.platform == 'win32':
self.skipTest("No support for Windows yet")
libdir = os.path.dirname(IMP.__file__)
cmake_cache = os.path.join(libdir, '..', '..', 'CMakeCache.txt')
if not os.path.exists(cmake_cache):
Expand Down

0 comments on commit 196959f

Please sign in to comment.