Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade to node >=20 #150

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: upgrade to node >=20 #150

merged 1 commit into from
Nov 4, 2024
+11 −11

Conversation

maliroteh-sf
Copy link
Contributor

What does this PR do?

Upgrade to node >=20

@maliroteh-sf maliroteh-sf requested a review from a team as a code owner November 4, 2024 18:06
@sfdctaka
Copy link
Contributor

sfdctaka commented Nov 4, 2024

Do we want to delete package-lock.json?

@maliroteh-sf
Copy link
Contributor Author

Do we want to delete package-lock.json?

@sfdctaka This repo does not use yarn so did you mean whether we want to delete package-lock.json and then run npm install to regenerate the file with updated dep versions? We now have dependabot for such things so I didn't do such update in this PR and tried to keep it as simple as possible.

@sfdctaka
Copy link
Contributor

sfdctaka commented Nov 4, 2024

I made a mistake. I thought github had package-lock.json as deleted. Instead, the file is too big it didn't show the diff by default.

sfdctaka
sfdctaka approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sfdctaka sfdctaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maliroteh-sf maliroteh-sf merged commit 5cd0ed2 into main Nov 4, 2024
13 checks passed
@maliroteh-sf maliroteh-sf deleted the node branch November 4, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfdctaka sfdctaka sfdctaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maliroteh-sf @sfdctaka