Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W 16554282.library upgrade #991

Merged
merged 14 commits into from
Sep 10, 2024
Merged

W 16554282.library upgrade #991

merged 14 commits into from
Sep 10, 2024

Conversation

peterzxu-crm
Copy link
Contributor

No description provided.

sholavanalli
sholavanalli previously approved these changes Sep 9, 2024
@@ -2,19 +2,18 @@ buildscript {
repositories {
mavenCentral()
mavenLocal()
jcenter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we removing this repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, in this PR, I am upgrading gradle 8 as well.

sholavanalli
sholavanalli previously approved these changes Sep 9, 2024
@peterzxu-crm
Copy link
Contributor Author

For the reviewers, here is the comparison for unit tests run after junit 5 upgrade.

From master branch https://github.com/salesforce/carbonj/actions/runs/10777842312/job/29887850825

> Task :carbonj.service:test

-------------------------------------------------------------------------
|  Results: SUCCESS (218 tests, 199 successes, 0 failures, 19 skipped)  |
-------------------------------------------------------------------------
Finished generating test XML results (0.048 secs) into: /home/runner/work/carbonj/carbonj/carbonj.service/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.076 secs) into: /home/runner/work/carbonj/carbonj/carbonj.service/build/reports/tests/test
Watching 128 directories to track changes
Watching 133 directories to track changes
Watching 134 directories to track changes
Resolve mutations for :carbonj.service:check (Thread[Execution worker Thread 2,5,main]) started.
:carbonj.service:check (Thread[Execution worker Thread 2,5,main]) started.

From the branch run https://github.com/salesforce/carbonj/actions/runs/10780946484/job/29897781499

> Task :carbonj.service:test

-------------------------------------------------------------------------
|  Results: SUCCESS (219 tests, 200 successes, 0 failures, 19 skipped)  |
-------------------------------------------------------------------------
Finished generating test XML results (0.061 secs) into: /home/runner/work/carbonj/carbonj/carbonj.service/build/test-results/test
Generating HTML test report...
Finished generating test html results (0.06 secs) into: /home/runner/work/carbonj/carbonj/carbonj.service/build/reports/tests/test
Resolve mutations for :carbonj.service:check (Thread[Execution worker,5,main]) started.
:carbonj.service:check (Thread[Execution worker,5,main]) started.

@slodha slodha merged commit f1ea74b into master Sep 10, 2024
7 checks passed
@slodha slodha deleted the W-16554282.library-upgrade branch September 10, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants