Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Package related fixes #5

Merged
merged 4 commits into from
Dec 18, 2024
Merged

GitHub Package related fixes #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00a2b9a
Update package name
dukhovnyi Dec 12, 2024
82e07f5
Fix incorrect param name for Android plugin
dukhovnyi Dec 18, 2024
efe1f5b
Add necessary permissions for getting access to cam and mic
dukhovnyi Dec 18, 2024
13c151e
token experiment
dukhovnyi Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/npm-publish-github-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,14 @@ on:
description: 'Version in semantic versioning format (i.e. 1.0.2)'
required: true
jobs:
publish:
package_publishing:
runs-on: ubuntu-latest
permissions:
contents: read
packages: write
id-token: write
env:
ACTIONS_STEP_DEBUG: true
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
steps:
- uses: actions/checkout@v4
Expand All @@ -27,7 +28,7 @@ jobs:
scope: '@salemove'

- name: Authenticate to GitHub Packages
run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.PAT_TOKEN }}" > ~/.npmrc
run: echo "//npm.pkg.github.com/:_authToken=${{ secrets.GITHUB_TOKEN }}" > ~/.npmrc

- name: Install dependencies
run: npm install
Expand Down
3 changes: 1 addition & 2 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
//npm.pkg.github.com/:_authToken=${GITHUB_TOKEN}
@salemove:registry=https://npm.pkg.github.com
@salemove:registry=https://npm.pkg.github.com/
4 changes: 2 additions & 2 deletions android/src/main/java/com/glia/widgets/ionic/GliaSdk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,10 +165,10 @@ public void showVisitorCodeViewController(PluginCall call, Activity activity) {
Authentication authentication;
public void authenticate(PluginCall call) {
String authRawBehaviorValue = call.getString("behavior");
String jwtToken = call.getString("jwtToken");
String jwtToken = call.getString("idToken");

if (jwtToken == null) {
call.reject("'jwtToken' is missing");
call.reject("'idToken' is missing");
return;
}
if (authRawBehaviorValue == null) {
Expand Down
6 changes: 6 additions & 0 deletions example-app/ios/App/App/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,12 @@
<key>NSAllowsArbitraryLoads</key>
<string>YES</string>
</dict>
<key>NSCameraUsageDescription</key>
<string>This app needs camera for audio/video calls and photo sending</string>
<key>NSMicrophoneUsageDescription</key>
<string>This app needs microphone for audio/video calls and for recording video</string>
<key>NSPhotoLibraryAddUsageDescription</key>
<string>Save attachments</string>
<key>UILaunchStoryboardName</key>
<string>LaunchScreen</string>
<key>UIMainStoryboardFile</key>
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "@salemove/glia-widgets-ionic",
"name": "@salemove/widgets_sdk_ionic",
"version": "1.0.0",
"description": "GliaWidgets SDK is a simple and customisable framework built on top of GliaSDK. It provides all the necessary UI components to quickly integrate GliaSDK into your project.",
"main": "dist/plugin.cjs.js",
Expand Down
Loading