Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expect full state in the "leaves" array #10

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

indrekj
Copy link
Member

@indrekj indrekj commented Nov 27, 2024

If there's an update to the state then we always have a "join". If it's just leave, then the state doesn't have to change, and we can use previously known state.

If there's an update to the state then we always have a "join". If it's
just leave, then the state doesn't have to change, and we can use
previously known state.
@indrekj indrekj requested review from zidik and laurglia November 27, 2024 09:51
Copy link

@laurglia laurglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are already changing the Phoenix library, maybe it makes sense to also remove properties besides phx_ref from the leaves here instead of doing it in the JSON encoder?

@indrekj
Copy link
Member Author

indrekj commented Nov 27, 2024

Hm. That would mean changing the server part as well. The current onChange part is our invention anyway, so I was more comfortable changing it. At least it doesn't move our fork more away from the upstream.

@indrekj indrekj merged commit 1a61c90 into v1.6.11-glia Nov 28, 2024
5 of 11 checks passed
@indrekj indrekj deleted the v1.6.11-glia-leaves-state branch November 28, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants