Handle unknown severity levels #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s22su
approved these changes
Mar 13, 2024
take-five
reviewed
Mar 13, 2024
Logger#add expects an integer in the first position.
The previous implementation mistakenly assumed the first position
argument to be a severity 'label' ('info').
urmastalimaa
force-pushed
the
handle_unknown_severity_levels
branch
from
c40aa3a to
449897a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lenjador#add accepts
severity. Fall back toinfowhen the severitycannot be mapped to a known "level" to not lose messages.
This was motivated by an external tool calling #add with 'any' severity.