Release/2.2.2 #832
Merged
Release/2.2.2 #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before these changes when visitor had subsequent engagements, but SDK was configured only once, interactor instance created on configuration step kept incorrect (not initial) state. As a result, SDK started to behave incorrectly. So we decided to not try to find each bug, but re-create interactor each time on start engagement action or requesting visitor code. This commit adds this functionality.
The new version of the Widgets SDK, which is represented in the Bitrise workflow as `$NEW_VERSION`, is sent to a script that executes the `update_dependencies` workflow in Cortex Financial. Then, in the Cortex side, the version of the widgets will be increased and a new PR made. As this is part of the `deployment` workflow for the widgets, this means that upon releasing widgets, nothing needs to be done from our side to update Cortex (apart from approving the PR in Cortex). MOB-2783
There was the issue when Proximity meter is kept on after having audio/video call. The problem was that `isProximityMonitoringEnabled` was not toggled back. The Proximity meter blocks user interactions and turns screen brightness off/on itself. So some redundant part of ProximityManager class was removed. MOB-2771
AppIcon in SDK assets may lead to replacing integrator application icon with Glia logo that is not acceptable.
Previously if WidgetsSDK is configured one time and then visitor has regular engagement, then CV engagement with screen sharing, if the operator ends CV engagement, bubble and screen sharing state is still displayed. It happened because EngagementViewModel called interator.endSession which set `isEngagementEndedByVisitor` to `true` even in case if engagement is ended by operator. Since CV engagement is started without additional `configure` call, interactor keeps `isEngagementEndedByVisitor` as `true`, which was broking CV flow. This commit fixes it. MOB-2731
Commit also includes several improvements: - filtering out empty queueIds; - depracation of old `configure` method; - replace checking interactor existance with configuration one to ensure SDK is configured; - improve error handling in TestingApp MOB-2784
The configuration accepts a manual locale override, which is `nil` by default. If the Core SDK returns an incorrect manual locale override, then the Widgets SDK also returns an error on configuration to let know the integrator about it. If the integrator provides a wrong site API key, this commit also makes sure to inform the integrator instead of hanging. Also, the settings screen now includes the possibility to add a manual locale override visually. If it's empty, then it sends nil. MOB-2798
EgorovEI
requested review from
igorkravchenko,
gersonnoboa,
rasmustautsglia and
yurii-glia
yurii-glia
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes:
Additional info:
Screenshots: