Add manual locale override capability #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gersonnoboa
requested review from
yurii-glia,
igorkravchenko,
EgorovEI and
rasmustautsglia
EgorovEI
approved these changes
Nov 3, 2023
rasmustautsglia
approved these changes
Nov 3, 2023
|
!squash |
The configuration accepts a manual locale override, which is `nil` by default. If the Core SDK returns an incorrect manual locale override, then the Widgets SDK also returns an error on configuration to let know the integrator about it. If the integrator provides a wrong site API key, this commit also makes sure to inform the integrator instead of hanging. Also, the settings screen now includes the possibility to add a manual locale override visually. If it's empty, then it sends nil. MOB-2798
sm-deployer
force-pushed
the
MOB-2798-merged
branch
from
59d0e79 to
6f60d56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-2798
What was solved?
The configuration accepts a manual locale override, which is
nilby default. If the Core SDK returns an incorrect manual locale override, then the Widgets SDK also returns an error on configuration to let know the integrator about it. If the integrator provides a wrong site API key, this commit also makes sure to inform the integrator instead of hanging.Also, the settings screen now includes the possibility to add a manual locale override visually. If it's empty, then it sends nil.
Release notes:
There's a new completion that is mandatory and that gives a Result, so that the integrator knows if there has been an issue with configuration instead of figuring it out when starting the engagement. Also, when creating the configuration, the integrator can add a
manualLocaleOverride.Additional info:
Screenshots: