Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce startEngagementWithConfig method with queueIds array #819

Merged

Conversation

EgorovEI
Copy link
Contributor

Jira issue:
https://glia.atlassian.net/browse/MOB-2761

What was solved?
Previously passing queues array was moved from configure method to startEngagement one. But startEngagementWithConfig was missed and was not extended by queueIds param.
That PR introduces new startEngagementWithConfig with queueIds params, deprecate previous public method.
Migration guide should enforce integrators use new interface, because due to "Re-create interactor" further changes will not be able to use old configure, startEngagement and startEngagementWithConfig methods.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Tests fixed, added? Unit, acceptance, snapshots?
  • Logging necessary for future troubleshooting of customer issues added?

Screenshots:

@EgorovEI EgorovEI requested a review from gersonnoboa October 24, 2023 08:51
@gersonnoboa
Copy link
Contributor

Would be good if Yurii checks it before merge, even if you have two approvals already, because you know that he had this task in his mind for some time.

@EgorovEI
Copy link
Contributor Author

!squash

@sm-deployer sm-deployer force-pushed the feature/MOB-2761-extend-start-engagement-interface branch from e531391 to 8da72eb Compare October 24, 2023 11:55
@EgorovEI EgorovEI merged commit 2f6c505 into development Oct 24, 2023
1 check passed
@EgorovEI EgorovEI deleted the feature/MOB-2761-extend-start-engagement-interface branch October 24, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants