Fix crash related to force unwrapping and unowned self #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were a couple of instances of unowned self and force unwrapping of a variable that could (and have) crashed the widgets under certain obscure circumstances. MOB-2773
gersonnoboa
requested review from
EgorovEI,
igorkravchenko,
rasmustautsglia and
yurii-glia
EgorovEI
approved these changes
Oct 20, 2023
rasmustautsglia
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue:
https://glia.atlassian.net/browse/MOB-2773
What was solved?
There were a couple of instances of unowned self and force unwrapping of a variable that could (and have) crashed the widgets under certain obscure circumstances.
Release notes:
Additional info:
Screenshots: