Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#I Remove L10n usage from unit tests #799

Merged
merged 1 commit into from
Oct 13, 2023
Merged

#I Remove L10n usage from unit tests #799

merged 1 commit into from
Oct 13, 2023

Conversation

gersonnoboa
Copy link
Contributor

@gersonnoboa gersonnoboa commented Oct 12, 2023 •
edited
Loading

Jira issue:
https://glia.atlassian.net/browse/MOB-2747

What was solved?
There were some tests that still used L10n strings, which are now deprecated.

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Tests fixed, added? Unit, acceptance, snapshots?
  • Logging necessary for future troubleshooting of customer issues added?

Screenshots:

@gersonnoboa
Remove L10n usage from unit tests
9a15e07 
There were some tests that still used L10n strings, which are now deprecated.

MOB-2747
@EgorovEI
Copy link
Contributor

Since changes are related to unit tests and will not be even described in Feature documentation, I would change #F tag to #I (Ignore)

@gersonnoboa gersonnoboa changed the title #F Remove L10n usage from unit tests #I Remove L10n usage from unit tests Oct 12, 2023
@gersonnoboa
Copy link
Contributor Author

@EgorovEI changed

@gersonnoboa gersonnoboa merged commit 0b488c3 into development Oct 13, 2023
1 check passed
@gersonnoboa gersonnoboa deleted the MOB-2747 branch October 13, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurii-glia yurii-glia yurii-glia approved these changes

@rasmustautsglia rasmustautsglia rasmustautsglia approved these changes

@EgorovEI EgorovEI EgorovEI approved these changes

@igorkravchenko igorkravchenko igorkravchenko approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gersonnoboa @EgorovEI @igorkravchenko @rasmustautsglia @yurii-glia