#F Add powered by to leave queue alert #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit syncs the leave queue alert to how Android works. Also, the end engagement alert now uses the `showsPoweredBy` variable. This means that it will now respect the global setting rather than always setting it as yes. This would bring issues if a client pays for hiding powered by, as it would be wrongly shown in that case. MOB-2742
gersonnoboa
requested review from
igorkravchenko,
EgorovEI,
rasmustautsglia and
yurii-glia
gersonnoboa
changed the title
yurii-glia
approved these changes
Oct 11, 2023
EgorovEI
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit syncs the leave queue alert to how Android works. Also, the end engagement alert now uses the
showsPoweredByvariable. This means that it will now respect the global setting rather than always setting it as yes. This would bring issues if a client pays for hiding powered by, as it would be wrongly shown in that case.MOB-2742