#F Change priority of company name algorithm #793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gersonnoboa
requested review from
igorkravchenko,
EgorovEI,
rasmustautsglia and
yurii-glia
gersonnoboa
changed the title
EgorovEI
approved these changes
Oct 10, 2023
yurii-glia
reviewed
Oct 11, 2023
Comment on lines
89
to
92
| if | ||
| let remoteCompanyName = stringProviding?.getRemoteString(companyNameStringKey), | ||
| !remoteCompanyName.isEmpty | ||
| { |
There was a problem hiding this comment.
didn't see this kind of formatting in our code base, would it make sense to align with other code or provide a new codebase style?
yurii-glia
approved these changes
Oct 11, 2023
igorkravchenko
approved these changes
Oct 11, 2023
rasmustautsglia
approved these changes
Oct 11, 2023
|
!squash |
Before, the UiTheme took the highest priority in the algorithm to determine the company name. Now the remote company name has the highest priority, with the added constraint that it cannot be empty, as this will be the default value on the default locale. In case it is empty, the UiTheme will come afterwards, then the SDK configuration, and finally the local fallback. MOB-2733
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the UiTheme took the highest priority in the algorithm to determine the company name. Now the remote company name has the highest priority, with the added constraint that it cannot be empty, as this will be the default value on the default locale. In case it is empty, the UiTheme will come afterwards, then the SDK configuration, and finally the local fallback.
MOB-2733