Convert ScreenSharingView to SwiftUI #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
igorkravchenko,
EgorovEI and
yurii-glia
EgorovEI
reviewed
Sep 27, 2023
GliaWidgets/Sources/CallVisualizer/ScreenSharing/Model/ScreenSharingViewModel.swift
Outdated
Show resolved
Hide resolved
...idgets/Sources/CallVisualizer/ScreenSharing/ViewController/ScreenSharingViewController.swift
Show resolved
Hide resolved
EgorovEI
approved these changes
Sep 27, 2023
yurii-glia
reviewed
Sep 27, 2023
GliaWidgets/Sources/CallVisualizer/ScreenSharing/Model/ScreenSharingViewModel.swift
Outdated
Show resolved
Hide resolved
...idgets/Sources/CallVisualizer/ScreenSharing/ViewController/ScreenSharingViewController.swift
Show resolved
Hide resolved
|
@rasmustautsglia could you also verify if adding SwiftUI works well in the case of using SwiftPackageManager? Feel free to integrate it as a local package to check it. |
rasmustautsglia
force-pushed
the
Convert-ScreenSharingView-to-SwiftUI
branch
from
2f45a67 to
8b034f1
Compare
|
We concluded with @yurii-glia that SwiftUI works well in case of using Swift Package Manager |
| .cornerRadius(4) | ||
| .padding(.horizontal, 60) | ||
| }) | ||
| .accessibility(identifier: "end_screen_sharing_button") |
There was a problem hiding this comment.
Do these accessibility related modifiers produce deprecation warnings? Maybe it makes sense to use migrationAccessibilityIdentifier + others (for label and hint) until we properly backport missing/deprecated features in SwiftUI for iOS 13?
There was a problem hiding this comment.
fixed for specific example and for all the other accessibility bb2ef12
There was a problem hiding this comment.
And here 860c457
igorkravchenko
approved these changes
Oct 3, 2023
rasmustautsglia
force-pushed
the
Convert-ScreenSharingView-to-SwiftUI
branch
2 times, most recently
from
ef4ae58 to
1069656
Compare
|
!squash |
This PR converts ScreenSharingView to SwiftUI MOB-2720
sm-deployer
force-pushed
the
Convert-ScreenSharingView-to-SwiftUI
branch
from
a1a631f to
29b34f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts ScreenSharingView from UIKit to SwiftUI
Snapshots PR: https://github.com/salemove/ios-widgets-snapshots/pull/51
MOB-2720