#I Improve snapshot test #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
EgorovEI,
gersonnoboa,
yurii-glia and
igorkravchenko
sm-deployer
force-pushed
the
Improve-Snapshot-tests
branch
2 times, most recently
from
0f5807d to
b22b684
Compare
EgorovEI
reviewed
Sep 25, 2023
EgorovEI
approved these changes
Sep 25, 2023
|
Please add FIRM tag to PR title |
There was a problem hiding this comment.
As we have discussed earlier, in my opinion, extending UIViewController to get snapshot references, makes all snapshots very specific - meaning that we will be forced to create same extension for UIView, SwiftUI.View etc, over and over. I think we should instead extend Snapshotting or SnapshotTestCase to keep snapshot matching value generic as it is right now in assertSnapshot<Value, Format> and get desired behaviour via method overload.
yurii-glia
approved these changes
Sep 26, 2023
|
Please re-review as the complete update has been added |
rasmustautsglia
requested review from
yurii-glia,
EgorovEI and
igorkravchenko
EgorovEI
approved these changes
Sep 27, 2023
fixed d23621c |
yurii-glia
approved these changes
Sep 27, 2023
This PR improves the way snapshot tests are executed. By creating an extension to UIViewController, we can now create snapshot tests with less code, time, and effort. And, it is much more readable. Since our usages of snapshot tests are very limited (for now), this approach serves those purposes very well. As this proposal is up for debate, I would like to hear everybody's input on it. Please share what are your thoughts on making this change. MOB-2696
rasmustautsglia
force-pushed
the
Improve-Snapshot-tests
branch
from
d23621c to
e39a873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way snapshot tests are executed. By creating an
extension to UIViewController, we can now create snapshot tests with
less code, time, and effort. And, it is much more readable. Since our
usages of snapshot tests are very limited (for now), this approach serves
those purposes very well.
This commit also updates the following:
correct naming, leaving out the dimensions of the view. This PR fixes that
and extra3LargeFont tests
Snapshots PR: https://github.com/salemove/ios-widgets-snapshots/pull/50
MOB-2696