Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#F StringProviding integration #779

Merged

Conversation

EgorovEI
Copy link
Contributor

StringProviding is set when configuration is done. Then this StringProviding will be used to retrieve remote string if exists, otherwise localized value is taken from local file.

Copy link
Contributor

@igorkravchenko igorkravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments regarding dependency injection.

Copy link
Contributor

@gersonnoboa gersonnoboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great, let's see what others say but it looks like the Core SDK interface is good.

@EgorovEI EgorovEI force-pushed the feature/integrate-get-remote-string-interface branch from 2550ea2 to f63c010 Compare September 22, 2023 13:11
@EgorovEI EgorovEI marked this pull request as ready for review September 22, 2023 13:15
@EgorovEI EgorovEI changed the title StringProviding integration #F StringProviding integration Sep 22, 2023
@EgorovEI
Copy link
Contributor Author

!squash

StringProviding is set when configuration is done. Then this StringProviding will be used to retrieve remote string if exists, otherwise localized value is taken from local file.
@sm-deployer sm-deployer force-pushed the feature/integrate-get-remote-string-interface branch from f63c010 to 8877933 Compare September 22, 2023 13:25
@EgorovEI EgorovEI merged commit ce4403c into custom-locales Sep 22, 2023
@EgorovEI EgorovEI deleted the feature/integrate-get-remote-string-interface branch September 22, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants