-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#F StringProviding integration #779
Merged
EgorovEI
merged 1 commit into
custom-locales
from
feature/integrate-get-remote-string-interface
Sep 22, 2023
Merged
#F StringProviding integration #779
EgorovEI
merged 1 commit into
custom-locales
from
feature/integrate-get-remote-string-interface
Sep 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorovEI
requested review from
igorkravchenko,
gersonnoboa,
rasmustautsglia and
yurii-glia
September 21, 2023 13:11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments regarding dependency injection.
igorkravchenko
approved these changes
Sep 21, 2023
gersonnoboa
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems great, let's see what others say but it looks like the Core SDK interface is good.
EgorovEI
force-pushed
the
custom-locales
branch
from
September 22, 2023 13:08
222e14f
to
fa6f4b5
Compare
EgorovEI
force-pushed
the
feature/integrate-get-remote-string-interface
branch
from
September 22, 2023 13:11
2550ea2
to
f63c010
Compare
gersonnoboa
approved these changes
Sep 22, 2023
!squash |
StringProviding is set when configuration is done. Then this StringProviding will be used to retrieve remote string if exists, otherwise localized value is taken from local file.
sm-deployer
force-pushed
the
feature/integrate-get-remote-string-interface
branch
from
September 22, 2023 13:25
f63c010
to
8877933
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringProviding is set when configuration is done. Then this StringProviding will be used to retrieve remote string if exists, otherwise localized value is taken from local file.