Add landscape snapshot testing capability #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa,
EgorovEI and
yurii-glia
rasmustautsglia
force-pushed
the
Add-landscape-snapshot-testing-capability
branch
from
fe018b2 to
f6b1502
Compare
gersonnoboa
approved these changes
Sep 18, 2023
EgorovEI
approved these changes
Sep 18, 2023
SnapshotTests/SnapshotTestCase.swift
Outdated
| let traits = UITraitCollection(traitsFrom: [ | ||
| .init(forceTouchCapability: .available), | ||
| .init(layoutDirection: .leftToRight), | ||
| .init(preferredContentSizeCategory: .medium), |
There was a problem hiding this comment.
It says preferredContentSizeCategory is .medium here, but below it overrides it with .accessibilityExtraExtraExtraLarge). Seem like medium is unnecessary?
Suggested change
| .init(preferredContentSizeCategory: .medium), |
There was a problem hiding this comment.
fixed 3a0d35b
SnapshotTests/SnapshotTestCase.swift
Outdated
| extension Snapshotting where Value == UIViewController, Format == UIImage { | ||
| static var extra3LargeFontStrategyLandscape: Self { | ||
| let traits = UITraitCollection(traitsFrom: [ | ||
| .init(forceTouchCapability: .available), |
There was a problem hiding this comment.
Where do we use forceTouchCapability?
There was a problem hiding this comment.
We don't as far as I know. Those traits were taken from the other available iPhone models, because unfortunately iPhone 13 is not available. Perhaps this allows some other kind of testing and those traits are just bundled together for easier use.
| return Self.image(on: viewImageConfig) | ||
| } | ||
|
|
||
| static var imageLandscape: Self { |
There was a problem hiding this comment.
It seems like most of the trait collection items are the same, so we can put them in one reusable list:
private static var commonTraitCollection: [UITraitCollection] = [
.init(forceTouchCapability: .available),
.init(layoutDirection: .leftToRight),
.init(preferredContentSizeCategory: .medium),
.init(userInterfaceIdiom: .phone),
.init(horizontalSizeClass: .regular),
.init(verticalSizeClass: .compact),
]
static var extra3LargeFontStrategyLandscape: Self {
let traits = UITraitCollection(traitsFrom: [
.init(preferredContentSizeCategory: .accessibilityExtraExtraExtraLarge)
] + commonTraitCollection)
/// .....
static var imageLandscape: Self {
let traits = UITraitCollection(traitsFrom: commonTraitCollection)
/// .....
There was a problem hiding this comment.
fixed 3a0d35b
igorkravchenko
approved these changes
Sep 20, 2023
|
!squash |
This PR adds a capability to snapshot test screens in landscape, both with regular and large font. MOB-2653
sm-deployer
force-pushed
the
Add-landscape-snapshot-testing-capability
branch
from
b7bea6b to
3d55c01
Compare
rasmustautsglia
deleted the
Add-landscape-snapshot-testing-capability
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a capability to snapshot test screens in landscape, both with regular and large font.
MOB-2653