Convert ConfirmationView from UIKit to SwiftUI #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasmustautsglia
changed the title
rasmustautsglia
requested review from
igorkravchenko,
gersonnoboa,
EgorovEI and
yurii-glia
rasmustautsglia
force-pushed
the
Convert-ConfirmationView-from-UIKit-to-SwiftUI
branch
from
e3a5fcd to
5e452cc
Compare
rasmustautsglia
force-pushed
the
Convert-ConfirmationView-from-UIKit-to-SwiftUI
branch
2 times, most recently
from
45a7410 to
5051718
Compare
rasmustautsglia
force-pushed
the
Convert-ConfirmationView-from-UIKit-to-SwiftUI
branch
from
5e700f7 to
3fc3927
Compare
EgorovEI
reviewed
Sep 15, 2023
...idgets/SecureConversations/Confirmation/SecureConversations.ConfirmationViewController.swift
Outdated
Show resolved
Hide resolved
EgorovEI
reviewed
Sep 15, 2023
SnapshotTests/SecureConversationsConfirmationScreenLayoutTests.swift
Outdated
Show resolved
Hide resolved
| renderProps() | ||
| struct ConfirmationViewSwiftUI: View { | ||
| @ObservedObject var model: Model | ||
| @ObservedObject var orientation: OrientationManager |
There was a problem hiding this comment.
I think it will be beneficial in terms of have single source of truth to make orientation a part of Model.
There was a problem hiding this comment.
Currently it is not possible
There was a problem hiding this comment.
Here's how it could be achieved f448682.
And I think OrientationManager can be injected as dependency itself.
There was a problem hiding this comment.
Fixed dc39037
|
!squash |
sm-deployer
force-pushed
the
Convert-ConfirmationView-from-UIKit-to-SwiftUI
branch
from
added37 to
0946736
Compare
igorkravchenko
approved these changes
Sep 21, 2023
|
!squash |
This PR is experimental, yet important first step towards transitioning to SwiftUI. ConfirmationView has been rewritten entirely in SwiftUI. The primary motivator for this PR was the frustrating nature of UIKit constraints. Key factors to keep in mind while reviewing: 1. Checkmark image has been made smaller, which was the request from the design team 2. UIFont does not translate 1:1 to SwiftUI Font, meaning the same font looks just a little big different now. But dynamic scaling works, and all our default fonts translate to expected outcome (font size, weight etc.) 3. Some approaches used in view layouts is due to the restrictions of SwiftUI 1.0 capabilities. Those can and will be upgraded in the future 4. The naming of Views, and Objects, as well as file locations in the directory are up for discussion. Everyone's input is much appreciated. 5. Prefix SwiftUI is used in lots of places due to a conflict with existing custom objects Button and Image 6. New HeaderSwiftUI view does not include all the possible configuration possibilities, as confirmations view's needs are not very demanding. So, that view can be upgraded in future. This PR also covers the ticket MOB-2488 which focuses on ADA-compliance in ConfigurationsView
sm-deployer
force-pushed
the
Convert-ConfirmationView-from-UIKit-to-SwiftUI
branch
from
54d5356 to
2f7eb17
Compare
rasmustautsglia
deleted the
Convert-ConfirmationView-from-UIKit-to-SwiftUI
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an experimental, yet important first step towards transitioning to
SwiftUI.ConfirmationViewhas been rewritten entirely inSwiftUI. The primary motivator for this PR was the frustrating nature of UIKit constraints.Key factors to keep in mind while reviewing:
The checkmark image has been made smaller, which was the request from the design team
UIFontdoes not translate 1:1 toSwiftUIFont, meaning the same font looks just a little bit different now. But dynamic scaling works and all our default fonts translate to the expected outcome (font size, weight, etc.)Some approaches used in view layouts are due to the restrictions of
SwiftUI1.0 capabilities. Those can and will be upgraded in the futureThe naming of Views, and Objects, as well as file locations in the directory are up for discussion. Everyone's input is much appreciated.
Prefix
SwiftUIis used in lots of places due to a conflict with existing custom objectsButtonandImageThe new HeaderSwiftUI view does not include all the possible configuration possibilities, as the
ConfirmationView's needs are not very demanding. So, that view can be upgraded in the future.This PR also covers the ticket MOB-2488 which focuses on ADA compliance in
ConfirmationViewSnapshot image reference PR: https://github.com/salemove/ios-widgets-snapshots/pull/47
#I