Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling engagement ended flow #1169

Open
wants to merge 1 commit into
base: feature/entry-widget-and-secure-conversations-v2
Choose a base branch
from
Open

Fix handling engagement ended flow #1169

wants to merge 1 commit into from

Conversation

EgorovEI
Copy link
Contributor

MOB-3897

What was solved?
This PR introduces endedEngagement property in Interactor for storing engagement ended by operator to fetch a survey

Release notes:

  • Feature
  • Ignore
  • Release notes (Is it clear from the description here?)
  • Migration guide (If changes are needed for integrator already using the SDK - what needs to be communicated? Add underneath please)

Additional info:

  • Is the feature sufficiently tested? All tests fixed? Necessary unit, acceptance, snapshots added? Check that at least new public classes & methods are covered with unit tests
  • Did you add logging beneficial for troubleshooting of customer issues?
  • Did you add new logging? We would like the logging between platforms to be similar. Refer to Logging from iOS SDKs → Things to consider for newly added logs in Confluence for more information.

Fix handling engagement ended flow
90d5534 
This commit introduces `endedEngagement` property in Interactor for storing engagement ended by operator to fetch a survey

MOB-3897
ykyivskyi-gl
ykyivskyi-gl approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@ykyivskyi-gl ykyivskyi-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a small note, we keep expanding the state of interactor, seems that it is good candidate for refactoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykyivskyi-gl ykyivskyi-gl ykyivskyi-gl approved these changes

@igorkravchenko igorkravchenko Awaiting requested review from igorkravchenko

@rasmustautsglia rasmustautsglia Awaiting requested review from rasmustautsglia

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgorovEI @ykyivskyi-gl